chore: update accounts related packages#27284
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
8bd75b4 to
afb0da7
Compare
3 tasks
Collaborator
Builds ready [36456ee]
Page Load Metrics (1775 ± 112 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
b02fbc2 to
169140b
Compare
Collaborator
Builds ready [169140b]
Page Load Metrics (1973 ± 88 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
af8589c to
c991601
Compare
Collaborator
Builds ready [c991601]
Page Load Metrics (1649 ± 65 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
c991601 to
aa53ef3
Compare
aa53ef3 to
720cf81
Compare
Collaborator
Builds ready [720cf81]
Page Load Metrics (2014 ± 92 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Collaborator
Builds ready [0f337dc]
Page Load Metrics (2139 ± 89 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
danroc
reviewed
Sep 27, 2024
Collaborator
Builds ready [8a913b9]
Page Load Metrics (2152 ± 105 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
danroc
previously approved these changes
Sep 27, 2024
ccharly
commented
Sep 30, 2024
| "1": "string", | ||
| "2": "string" | ||
| } | ||
| "srcNetworkAllowlist": { "0": "string", "1": "string", "2": "string" }, |
Contributor
Author
There was a problem hiding this comment.
IDK why this got pretty-print differently, maybe our prettier/eslint config got updated. Anyway, the CI is happy with that change :)
montelaidev
previously approved these changes
Sep 30, 2024
|
Collaborator
Builds ready [1f2da0a]
Page Load Metrics (1848 ± 117 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
|
Tested commit 1fdad0a with Chrome 129 and Firefox 131 in mac sonoma 14.6.1 Tested migration in Chrome from 11.16.16 to 1fdad0a Was able to add HD accounts, import pk, remove accounts, add hardware, remove hardware account, forget hardware, add and remove SSK accounts, sign, send, lock and unlock, pin and hide accounts, dapp connect. Also tested fresh install with create new wallet and restore SRP. |
danroc
approved these changes
Oct 7, 2024
montelaidev
approved these changes
Oct 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updating packages to use versions coming from the new accounts monorepo.
Related issues
Related to:
Manual testing steps
Test parts of the extension that closely related to accounts management + HW wallets support.
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist