Skip to content

ci: Expand github bot policy update comment to be more actionable#27242

Merged
naugtur merged 2 commits intodevelopfrom
naugtur-policy-bot-message
Sep 30, 2024
Merged

ci: Expand github bot policy update comment to be more actionable#27242
naugtur merged 2 commits intodevelopfrom
naugtur-policy-bot-message

Conversation

@naugtur
Copy link
Copy Markdown
Contributor

@naugtur naugtur commented Sep 18, 2024 •
edited
Loading

Description

Surface the need for review and docs on how to do it

Screenshots/Recordings

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@naugtur naugtur requested a review from a team as a code owner September 18, 2024 09:44
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 18, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Sep 18, 2024
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Sep 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Sep 18, 2024

Builds ready [3837aea]
Page Load Metrics (1907 ± 84 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint23623251750505242
domContentLoaded16302315188517082
load16382329190717484
domInteractive16100532210
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@naugtur naugtur added team-lavamoat and removed INVALID-PR-TEMPLATE PR's body doesn't match template labels Sep 19, 2024
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Sep 19, 2024
@naugtur naugtur force-pushed the naugtur-policy-bot-message branch from 3837aea to e3cf10a Compare September 19, 2024 10:16
@naugtur naugtur changed the title Expand github bot policy update comment to be more actionable ci: Expand github bot policy update comment to be more actionable Sep 19, 2024
@naugtur naugtur force-pushed the naugtur-policy-bot-message branch 3 times, most recently from 952aa1c to cd4564e Compare September 23, 2024 09:28
@naugtur naugtur removed the INVALID-PR-TEMPLATE PR's body doesn't match template label Sep 25, 2024
@naugtur naugtur force-pushed the naugtur-policy-bot-message branch from cd4564e to 7d97787 Compare September 25, 2024 12:16
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Sep 25, 2024

Builds ready [7d97787]
Page Load Metrics (1988 ± 116 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint37326711913433208
domContentLoaded167126221939231111
load168426811988242116
domInteractive24101472110
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

hmalik88
hmalik88 previously approved these changes Sep 25, 2024
View reviewed changes
sahar-fehri
sahar-fehri previously approved these changes Sep 30, 2024
View reviewed changes
naugtur
naugtur commented Sep 30, 2024
View reviewed changes
@naugtur naugtur dismissed stale reviews from sahar-fehri and hmalik88 via 899e2e9 September 30, 2024 09:12
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Sep 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Sep 30, 2024

Builds ready [899e2e9]
Page Load Metrics (1946 ± 179 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint28428371888529254
domContentLoaded138527511909346166
load139227751946373179
domInteractive157242168
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@naugtur naugtur merged commit 2eebe1b into develop Sep 30, 2024
@naugtur naugtur deleted the naugtur-policy-bot-message branch September 30, 2024 10:37
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sahar-fehri sahar-fehri sahar-fehri approved these changes

@hmalik88 hmalik88 Awaiting requested review from hmalik88

+1 more reviewer

@leotm leotm leotm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-lavamoat

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@naugtur @metamaskbot @leotm @sahar-fehri @hmalik88