feat: convert account tracker to typescript by cryptodev-2s · Pull Request #27231 · MetaMask/metamask-extension

cryptodev-2s · 2024-09-17T22:04:58Z

Description

Convert AccountTracker (implementation + tests) to TypeScript

Related issues

Fixes: #25928

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-09-17T22:05:12Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

sonarqubecloud · 2024-09-17T22:40:32Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-09-17T23:14:20Z

Builds ready [1b07a49]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1629 ± 70 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	194	2202	1494	420	201
		domContentLoaded	1458	2016	1596	132	63
		load	1466	2104	1629	145	70
		domInteractive	13	170	45	44	21

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 831 Bytes (0.02%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

codecov · 2024-09-17T23:15:33Z

Codecov Report

Attention: Patch coverage is 75.86207% with 14 lines in your changes missing coverage. Please review.

Project coverage is 69.99%. Comparing base (bc7929b) to head (1b07a49).

Files with missing lines	Patch %	Lines
app/scripts/lib/account-tracker.ts	75.86%	14 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #27231      +/-   ##
===========================================
- Coverage    70.02%   69.99%   -0.03%     
===========================================
  Files         1443     1443              
  Lines        50164    50172       +8     
  Branches     14039    14046       +7     
===========================================
- Hits         35126    35115      -11     
- Misses       15038    15057      +19

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

app/scripts/lib/account-tracker.ts

app/scripts/metamask-controller.js

metamaskbot · 2024-09-26T20:18:19Z

Builds ready [f47e2cd]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1744 ± 107 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1485	2442	1753	239	115
		domContentLoaded	1478	2253	1718	213	102
		load	1486	2339	1744	222	107
		domInteractive	14	95	39	20	10

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 831 Bytes (0.02%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

…ript

sonarqubecloud · 2024-09-29T17:33:31Z

Quality Gate failed

Failed conditions
75.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

metamaskbot · 2024-09-29T17:50:48Z

Builds ready [49410d3]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1812 ± 92 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	338	2233	1643	446	214
		domContentLoaded	1606	2392	1789	183	88
		load	1614	2411	1812	191	92
		domInteractive	14	77	41	17	8

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 831 Bytes (0.02%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

NiranjanaBinoy

LGTM

app/scripts/lib/account-tracker.ts

MajorLift

LGTM!

cryptodev-2s requested a review from a team as a code owner September 17, 2024 22:04

github-actions bot added the team-wallet-framework label Sep 17, 2024

cryptodev-2s force-pushed the feature/convert-account-tracker-to-typescript branch 6 times, most recently from 4d56847 to c85633a Compare September 17, 2024 22:37

feat: convert account tracker to typescript

1b07a49

cryptodev-2s force-pushed the feature/convert-account-tracker-to-typescript branch from c85633a to 1b07a49 Compare September 17, 2024 22:38

cryptodev-2s mentioned this pull request Sep 18, 2024

feat: Migrate AccountTrackerController to BaseController v2 #27258

Merged

7 tasks

cryptodev-2s requested a review from a team September 18, 2024 15:30

desi assigned cryptodev-2s Sep 23, 2024