fix: alert system and refine SIWE and contract interaction alerts#27205
Merged
vinistevam merged 27 commits intodevelopfrom Sep 26, 2024
Merged
fix: alert system and refine SIWE and contract interaction alerts#27205vinistevam merged 27 commits intodevelopfrom
vinistevam merged 27 commits intodevelopfrom
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
Builds ready [8fa2cd6]
Page Load Metrics (1543 ± 72 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #27205 +/- ##
===========================================
+ Coverage 70.01% 70.01% +0.01%
===========================================
Files 1445 1445
Lines 50194 50199 +5
Branches 14041 14043 +2
===========================================
+ Hits 35139 35146 +7
+ Misses 15055 15053 -2 ☔ View full report in Codecov by Sentry. |
app/_locales/en/messages.json
Outdated
| @@ -1019,10 +1019,10 @@ | |||
| "message": "I have acknowledged the alert and still want to proceed" | |||
| }, | |||
| "confirmAlertModalDetails": { | |||
Contributor
There was a problem hiding this comment.
To change the copy correctly and trigger new translations, you can add the new copy under a new translation key, and delete the old key in all languages.
Contributor
Author
There was a problem hiding this comment.
Oh, thanks for pointing that out. I've applied the recommended changes. 474affa
pedronfigueiredo
requested changes
Sep 17, 2024
Contributor
pedronfigueiredo
left a comment
There was a problem hiding this comment.
LGTM, just left one comment regarding the translation files
|
Collaborator
Builds ready [474affa]
Page Load Metrics (1732 ± 107 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Collaborator
Builds ready [14d6c72]
Page Load Metrics (1768 ± 85 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [7b18c80]
Page Load Metrics (1866 ± 71 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
pedronfigueiredo
previously approved these changes
Sep 19, 2024
matthewwalsh0
requested changes
Sep 19, 2024
ui/components/app/alert-system/confirm-alert-modal/confirm-alert-modal.tsx
Outdated
Show resolved
Hide resolved
pedronfigueiredo
previously approved these changes
Sep 23, 2024
Collaborator
Builds ready [1349889]
Page Load Metrics (1855 ± 89 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
digiwand
previously approved these changes
Sep 24, 2024
Contributor
digiwand
left a comment
There was a problem hiding this comment.
PR looks good! added 1 non-blocking suggestion
merge conflicts are blocking merge
ui/components/app/alert-system/confirm-alert-modal/confirm-alert-modal.tsx
Outdated
Show resolved
Hide resolved
c2c041b
Collaborator
Builds ready [613b40d]
Page Load Metrics (2092 ± 169 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
edd9c7c to
613b40d
Compare
pedronfigueiredo
approved these changes
Sep 25, 2024
matthewwalsh0
approved these changes
Sep 25, 2024
|
Collaborator
Builds ready [c9dc17d]
Page Load Metrics (1931 ± 97 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to apply fixes and improvements to the Alert System in general and specific alerts such as SIWE and contract interaction.
Fixes:
1- Display a more generic and toned-down message on the friction modal.
2- Show alerts before the Confirm Alert Modal (final friction modal) when there is a danger alert.
3- Fixed CTA button when the alert has not been acknowledged.
Fixes from UX QA feedback
Figma
security-searchicon when button isReview AlertsorReview Alert- ✔️Xbutton - ✔️Related issues
Fixes: #27132 #27147 #27118
Manual testing steps
Case 1
Case 2
Case 3
Case 4
Screenshots/Recordings
alert-fix.webm
mint-without-funds.webm
Contract.Interaction.and.Alerts.webm
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist