fix: Adding patch on eth-json-rpc-middleware to disable verifyContract field validation for cosmos by jpuri · Pull Request #27021 · MetaMask/metamask-extension

jpuri · 2024-09-10T10:44:33Z

Description

Adding patch on eth-json-rpc-middleware to disable verifyContract field validation for cosmos

Related issues

Fixes: #26980

Manual testing steps

Submit a types signature request with verifyingContract set to cosmos
Ensure that you are able to sign it

Screenshots/Recordings

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…ld validation for cosmos

github-actions · 2024-09-10T10:44:47Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2024-09-10T10:45:24Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/eth-block-tracker@9.0.3	None	`0`	64.5 kB	lgbot
npm/@metamask/eth-json-rpc-provider@3.0.2	None	`0`	75.8 kB	metamaskbot

🚮 Removed packages: npm/@metamask/eth-block-tracker@11.0.1, npm/@metamask/eth-json-rpc-middleware@14.0.1, npm/@metamask/eth-json-rpc-provider@4.1.3, npm/klona@2.0.6

View full report↗︎

jpuri · 2024-09-10T14:04:56Z

@metamaskbot update-policies

metamaskbot · 2024-09-10T14:16:23Z

Policies updated

metamaskbot · 2024-09-10T14:53:06Z

Builds ready [b7be78f]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1734 ± 81 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	291	2224	1668	362	174
		domContentLoaded	1523	2161	1713	164	79
		load	1533	2172	1734	169	81
		domInteractive	24	66	41	14	7

Bundle size diffs [🚀 Bundle size reduced!]

background: -28.64 KiB (-0.84%)
ui: 0 Bytes (0.00%)
common: -56.61 KiB (-0.72%)

metamaskbot · 2024-09-10T16:12:09Z

Builds ready [7bb95d9]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1772 ± 56 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1555	1968	1775	116	56
		domContentLoaded	1514	1957	1750	112	54
		load	1554	1969	1772	116	56
		domInteractive	12	91	38	19	9

Bundle size diffs [🚀 Bundle size reduced!]

background: -28.64 KiB (-0.84%)
ui: 0 Bytes (0.00%)
common: -56.61 KiB (-0.72%)

digiwand

Looks good 👍🏼

I think we can update the description from
Fixes: TODO to Fixes: https://github.com/MetaMask/metamask-extension/issues/26980

It is worth mentioning that the solution appears to have been carried over from MetaMask/eth-json-rpc-middleware#333 (original), created by @mtsitrin, and applied as a patch.

We are applying this as a patch while continuing to discuss handling the verifyingContract spec. Without the patch, the eth-json-rpc-middleware enforces verifyingContracts as an Ethereum contract address in hex format. We are patching this to fix uses of cosmos chains using the https://github.com/evmos/ethermint EVM adapter

metamaskbot · 2024-09-11T08:33:34Z

Builds ready [f2c786d]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1887 ± 61 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	262	2111	1800	371	178
		domContentLoaded	1636	2090	1862	127	61
		load	1645	2106	1887	127	61
		domInteractive	15	69	36	11	5

Bundle size diffs [🚀 Bundle size reduced!]

background: -28.64 KiB (-0.84%)
ui: 0 Bytes (0.00%)
common: -56.61 KiB (-0.72%)

codecov · 2024-09-11T08:33:41Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.15%. Comparing base (3797b2f) to head (debeefb).

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #27021   +/-   ##
========================================
  Coverage    70.15%   70.15%           
========================================
  Files         1425     1425           
  Lines        49656    49656           
  Branches     13892    13892           
========================================
  Hits         34833    34833           
  Misses       14823    14823

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

legobeat · 2024-09-11T09:24:33Z

package.json

    "@metamask/keyring-controller@npm:^17.1.0": "patch:@metamask/keyring-controller@npm%3A17.1.1#~/.yarn/patches/@metamask-keyring-controller-npm-17.1.1-098cb41930.patch",
-    "@trezor/connect-web@npm:^9.1.11": "patch:@trezor/connect-web@npm%3A9.3.0#~/.yarn/patches/@trezor-connect-web-npm-9.3.0-040ab10d9a.patch"
+    "@trezor/connect-web@npm:^9.1.11": "patch:@trezor/connect-web@npm%3A9.3.0#~/.yarn/patches/@trezor-connect-web-npm-9.3.0-040ab10d9a.patch",
+    "@metamask/eth-json-rpc-middleware@npm:^12.1.1": "patch:@metamask/eth-json-rpc-middleware@npm%3A14.0.1#~/.yarn/patches/@metamask-eth-json-rpc-middleware-npm-14.0.1-b6c2ccbe8c.patch"


This forces all usage eth-json-rc-middleware from v12 to v14. While upgrading to v14 seems good, perhaps most safely done separately and this PR can path onto existing v12 as well as directly used v14?

Good catch @legobeat , I removed this line of code.

metamaskbot · 2024-09-11T09:53:14Z

Builds ready [b7e6c13]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1708 ± 55 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	245	1899	1633	338	162
		domContentLoaded	1535	1882	1693	107	51
		load	1542	1889	1708	114	55
		domInteractive	15	77	38	16	8

Bundle size diffs [🚀 Bundle size reduced!]

background: -28.64 KiB (-0.84%)
ui: 0 Bytes (0.00%)
common: -56.61 KiB (-0.72%)

…etamask-extension into eth_json_rpc_middleware_patch

jpuri · 2024-09-11T10:21:28Z

@metamaskbot update-policies

metamaskbot · 2024-09-11T10:32:47Z

Policies updated

sonarqubecloud · 2024-09-11T10:52:04Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-09-11T12:31:21Z

Builds ready [debeefb]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1641 ± 84 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1421	2011	1638	174	84
		domContentLoaded	1415	2004	1622	170	82
		load	1422	2011	1641	175	84
		domInteractive	22	104	42	21	10

Adding patch on eth-json-rpc-middleware to disable verifyContract fie…

a8fe45a

…ld validation for cosmos

github-actions bot added the team-confirmations Push issues to confirmations team label Sep 10, 2024

Merge branch 'develop' into eth_json_rpc_middleware_patch

4a33678

Update LavaMoat policies

b7be78f

jpuri marked this pull request as ready for review September 10, 2024 15:40

jpuri requested review from a team as code owners September 10, 2024 15:40

Merge branch 'develop' into eth_json_rpc_middleware_patch

7bb95d9

digiwand previously approved these changes Sep 10, 2024

View reviewed changes

Merge branch 'develop' into eth_json_rpc_middleware_patch

f2c786d

Merge branch 'develop' into eth_json_rpc_middleware_patch

b7e6c13

legobeat reviewed Sep 11, 2024

View reviewed changes

jpuri added 3 commits September 11, 2024 15:40

update

1fe9a7f

update

a745cbb

Merge branch 'eth_json_rpc_middleware_patch' of github.com:MetaMask/m…

0fa5aed

…etamask-extension into eth_json_rpc_middleware_patch

jpuri dismissed digiwand’s stale review via 0fa5aed September 11, 2024 10:12

Update LavaMoat policies

8a17155

Merge branch 'develop' into eth_json_rpc_middleware_patch

debeefb

jpuri requested review from digiwand and legobeat September 11, 2024 12:08

pedronfigueiredo approved these changes Sep 11, 2024

View reviewed changes

matthewwalsh0 approved these changes Sep 11, 2024

View reviewed changes

jpuri merged commit 4ee09fc into develop Sep 11, 2024

jpuri deleted the eth_json_rpc_middleware_patch branch September 11, 2024 13:22

github-actions bot locked and limited conversation to collaborators Sep 11, 2024

metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 11, 2024

metamaskbot added release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Sep 29, 2024

Conversation

jpuri commented Sep 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Sep 10, 2024

Uh oh!

socket-security bot commented Sep 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jpuri commented Sep 10, 2024

Uh oh!

metamaskbot commented Sep 10, 2024

Uh oh!

metamaskbot commented Sep 10, 2024

Uh oh!

metamaskbot commented Sep 10, 2024

Uh oh!

digiwand left a comment

Choose a reason for hiding this comment

Uh oh!

metamaskbot commented Sep 11, 2024

Uh oh!

codecov bot commented Sep 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

legobeat Sep 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jpuri Sep 11, 2024

Choose a reason for hiding this comment

Uh oh!

metamaskbot commented Sep 11, 2024

Uh oh!

jpuri commented Sep 11, 2024

Uh oh!

metamaskbot commented Sep 11, 2024

Uh oh!

sonarqubecloud bot commented Sep 11, 2024

Quality Gate passed

Uh oh!

metamaskbot commented Sep 11, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jpuri commented Sep 10, 2024 •

edited

Loading

socket-security bot commented Sep 10, 2024 •

edited

Loading

codecov bot commented Sep 11, 2024 •

edited

Loading

legobeat Sep 11, 2024 •

edited

Loading