Skip to content

feat: Display approve, increaseAllowance and revoke approval to users…#26985

Merged
pedronfigueiredo merged 1 commit intodevelopfrom
pnf/3246
Sep 26, 2024
Merged

feat: Display approve, increaseAllowance and revoke approval to users…#26985
pedronfigueiredo merged 1 commit intodevelopfrom
pnf/3246

Conversation

@pedronfigueiredo
Copy link
Copy Markdown
Contributor

@pedronfigueiredo pedronfigueiredo commented Sep 9, 2024 •
edited
Loading

… that opt-in

Description

This makes these redesigned screens available for users that opt into redesigned transaction screens in the experimental settings page.

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3246

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@pedronfigueiredo pedronfigueiredo added the team-confirmations Push issues to confirmations team label Sep 9, 2024
@pedronfigueiredo pedronfigueiredo self-assigned this Sep 9, 2024
@pedronfigueiredo pedronfigueiredo requested a review from a team as a September 9, 2024 09:53
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 9, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@pedronfigueiredo pedronfigueiredo requested a review from a team as a September 10, 2024 09:03
@pedronfigueiredo pedronfigueiredo force-pushed the pnf/3246 branch 2 times, most recently from a80f70c to 5bb5bf5 Compare September 10, 2024 09:24
matthewwalsh0
matthewwalsh0 previously approved these changes Sep 10, 2024
View reviewed changes
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.18%. Comparing base (26ca485) to head (5bb5bf5).

Additional details and impacted files 
@@            Coverage Diff            @@
##           pnf/3004   #26985   +/-   ##
=========================================
  Coverage     70.18%   70.18%           
=========================================
  Files          1431     1431           
  Lines         49750    49750           
  Branches      13917    13917           
=========================================
  Hits          34917    34917           
  Misses        14833    14833

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pedronfigueiredo pedronfigueiredo marked this pull request as draft September 12, 2024 16:48
@pedronfigueiredo pedronfigueiredo force-pushed the pnf/3004 branch 11 times, most recently from a36d58b to b23e4d7 Compare September 20, 2024 10:00
@pedronfigueiredo pedronfigueiredo force-pushed the pnf/3004 branch 4 times, most recently from 2cef806 to 70cced4 Compare September 24, 2024 09:05
@pedronfigueiredo pedronfigueiredo force-pushed the pnf/3004 branch 3 times, most recently from fef7bfa to bf919af Compare September 25, 2024 13:07
@pedronfigueiredo pedronfigueiredo marked this pull request as ready for review September 25, 2024 16:21
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Sep 25, 2024

Builds ready [fab8575]
Page Load Metrics (1919 ± 78 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint31523341840386185
domContentLoaded15852312189815976
load15902337191916378
domInteractive19132562914
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 7.06 KiB (0.10%)
  • common: 179 Bytes (0.00%)

Base automatically changed from pnf/3004 to develop September 26, 2024 08:29
@pedronfigueiredo pedronfigueiredo dismissed matthewwalsh0’s stale review September 26, 2024 08:29

The base branch was changed.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Sep 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@pedronfigueiredo pedronfigueiredo merged commit 255fdae into develop Sep 26, 2024
@pedronfigueiredo pedronfigueiredo deleted the pnf/3246 branch September 26, 2024 12:40
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jpuri jpuri jpuri approved these changes

@vinistevam vinistevam vinistevam approved these changes

@matthewwalsh0 matthewwalsh0 matthewwalsh0 left review comments

Assignees

@pedronfigueiredo pedronfigueiredo

Labels

release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-confirmations Push issues to confirmations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pedronfigueiredo @metamaskbot @jpuri @matthewwalsh0 @vinistevam