CherryPick: "fix: issue where wallet_addEtherumChain was incorrectly enforcing inclusion of a blockExplorerUrls property which is not required (#26938)"#26944
Merged
danjm merged 1 commit intoVersion-v12.2.0from Sep 5, 2024
Conversation
…nclusion of a blockExplorerUrls property which is not required (#26938) Fix issue where `wallet_addEtherumChain` was incorrectly enforcing inclusion of a blockExplorerUrls property which is not required ## **Description** [](https://codespaces.new/MetaMask/metamask-extension/pull/26938?quickstart=1) ## **Related issues** Fixes: #26844 ## **Manual testing steps** 1. Go to https://protect.flashbots.net/summary?fast=true 2. Click "Add to Metamask" 3. You should see the add network confirmation and be able to add the network configuration successfully to the wallet ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> https://github.com/user-attachments/assets/5c5718b5-f5e7-4499-9393-307bbe5c4eaa ### **After** https://github.com/user-attachments/assets/14d1b1aa-f2d8-4133-9056-064d7875379a ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
danjm
approved these changes
Sep 5, 2024
Collaborator
Builds ready [56d5505]
Page Load Metrics (1663 ± 86 ms)
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## Version-v12.2.0 #26944 +/- ##
===================================================
+ Coverage 70.48% 70.49% +0.01%
===================================================
Files 1400 1400
Lines 49577 49611 +34
Branches 13637 13647 +10
===================================================
+ Hits 34941 34971 +30
- Misses 14636 14640 +4 ☔ View full report in Codecov by Sentry. |
Collaborator
|
No release label on PR. Adding release label release-12.2.0 on PR, as PR was cherry-picked in branch 12.2.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue where
wallet_addEtherumChainwas incorrectly enforcing inclusion of a blockExplorerUrls property which is not requiredDescription
Related issues
Fixes: #26844
Manual testing steps
Screenshots/Recordings
Before
Screen.Recording.2024-09-05.at.9.53.27.AM.mov
After
Screen.Recording.2024-09-05.at.9.48.34.AM.mov
Pre-merge author checklist
Standards.
Pre-merge reviewer checklist
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist