Skip to content

fix: move porfolio button next to price amount#26867

Merged
jonybur merged 4 commits intodevelopfrom
jb/top-buttons-revision
Sep 4, 2024
Merged

fix: move porfolio button next to price amount#26867
jonybur merged 4 commits intodevelopfrom
jb/top-buttons-revision

Conversation

@jonybur
Copy link
Copy Markdown
Contributor

@jonybur jonybur commented Sep 3, 2024 •
edited
Loading

Description

Moves the portfolio button so that it's next to the token price amount.

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3201

Manual testing steps

  1. Go to the portfolio page
  2. Check that the Portfolio button is present next to the price amount of token
  3. Click it to test it works fine

Screenshots/Recordings

Screenshot 2024-09-03 at 22 57 32 Screenshot 2024-09-03 at 22 58 54

Before

Screenshot 2024-09-03 at 15 46 36

After

Screenshot 2024-09-03 at 22 58 54

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jonybur jonybur added the team-core-extension-ux Core Extension UX team label Sep 3, 2024
@jonybur jonybur requested a review from a team as a code owner September 3, 2024 14:47
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 3, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

EtherWizard33
EtherWizard33 previously approved these changes Sep 3, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@EtherWizard33 EtherWizard33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

NidhiKJha
NidhiKJha previously approved these changes Sep 3, 2024
View reviewed changes
@hesterbruikman
Copy link
Copy Markdown

hesterbruikman commented Sep 3, 2024 •
edited
Loading

@jonybur so sorry, we have a new change request while you still have this PR open; We'd also want to change the order of the buttons. I'll be able to confirm this most likely tomorrow. The order would be:

Buy/Sell
Swap
Bridge
Send
Receive

cc @mmragkandala

@mmragkandala
Copy link
Copy Markdown

mmragkandala commented Sep 3, 2024

I've also updated the designs in figma with this new ordering

image

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Sep 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.14%. Comparing base (dcea6ce) to head (b6fdfce).
Report is 20 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #26867      +/-   ##
===========================================
+ Coverage    70.12%   70.14%   +0.01%     
===========================================
  Files         1422     1424       +2     
  Lines        49526    49572      +46     
  Branches     13863    13868       +5     
===========================================
+ Hits         34730    34769      +39     
- Misses       14796    14803       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Sep 3, 2024

Builds ready [b6fdfce]
Page Load Metrics (1816 ± 94 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint33022851751377181
domContentLoaded15672246178017685
load15762283181619694
domInteractive187134147
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 97 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@jonybur jonybur requested a review from NidhiKJha September 3, 2024 22:36
EtherWizard33
EtherWizard33 approved these changes Sep 4, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@EtherWizard33 EtherWizard33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonybur jonybur merged commit 0e24ee3 into develop Sep 4, 2024
@jonybur jonybur deleted the jb/top-buttons-revision branch September 4, 2024 10:28
@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 4, 2024
@gauthierpetetin gauthierpetetin added release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@NidhiKJha NidhiKJha NidhiKJha approved these changes

+1 more reviewer

@EtherWizard33 EtherWizard33 EtherWizard33 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-12.5.0 Issue or pull request that will be included in release 12.5.0 team-core-extension-ux Core Extension UX team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@jonybur @hesterbruikman @mmragkandala @metamaskbot @NidhiKJha @EtherWizard33 @gauthierpetetin