feat: Change copy from estimated to network fee#26859
Merged
pedronfigueiredo merged 1 commit intodevelopfrom Sep 4, 2024
Merged
feat: Change copy from estimated to network fee#26859pedronfigueiredo merged 1 commit intodevelopfrom
pedronfigueiredo merged 1 commit intodevelopfrom
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
08f6061 to
5c92007
Compare
5c92007 to
0ae5a93
Compare
|
Collaborator
Builds ready [0ae5a93]
Page Load Metrics (1876 ± 103 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #26859 +/- ##
===========================================
- Coverage 70.13% 70.13% -0.00%
===========================================
Files 1424 1424
Lines 49571 49571
Branches 13867 13867
===========================================
- Hits 34765 34764 -1
- Misses 14806 14807 +1 ☔ View full report in Codecov by Sentry. |
matthewwalsh0
approved these changes
Sep 4, 2024
jpuri
approved these changes
Sep 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update copy and corresponding tests.
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3063
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist