fix: Apply padding to Snaps UI root element no matter the type#26850
Merged
FrederikBolding merged 1 commit intodevelopfrom Sep 3, 2024
Merged
fix: Apply padding to Snaps UI root element no matter the type#26850FrederikBolding merged 1 commit intodevelopfrom
FrederikBolding merged 1 commit intodevelopfrom
Conversation
|
david0xd
approved these changes
Sep 3, 2024
Collaborator
Builds ready [70f8b8e]
Page Load Metrics (1876 ± 119 ms)
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #26850 +/- ##
========================================
Coverage 70.13% 70.13%
========================================
Files 1424 1424
Lines 49567 49567
Branches 13867 13867
========================================
Hits 34759 34759
Misses 14808 14808 ☔ View full report in Codecov by Sentry. |
Mrtenz
approved these changes
Sep 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a problem where padding would not be applied correctly to the first child of the Snaps UI container. We were expecting all root elements to be
div. But many different types of components are allowed at the root. Quick fix by applying the padding no matter what type the root element is.Screenshots/Recordings
Before
After