Skip to content

test: add integration test for no gas price alert#26838

Merged
pnarayanaswamy merged 3 commits intodevelopfrom
no-gas-alert-it
Sep 4, 2024
Merged

test: add integration test for no gas price alert#26838
pnarayanaswamy merged 3 commits intodevelopfrom
no-gas-alert-it

Conversation

@pnarayanaswamy
Copy link
Copy Markdown
Contributor

@pnarayanaswamy pnarayanaswamy commented Sep 2, 2024 •
edited by github-actions bot
Loading

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@pnarayanaswamy pnarayanaswamy requested review from a team as code owners September 2, 2024 09:29
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 2, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-confirmations Push issues to confirmations team label Sep 2, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.12%. Comparing base (3f0b044) to head (c9ce5d4).
Report is 1 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #26838   +/-   ##
========================================
  Coverage    70.12%   70.12%           
========================================
  Files         1421     1421           
  Lines        49524    49524           
  Branches     13863    13863           
========================================
  Hits         34728    34728           
  Misses       14796    14796

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Sep 2, 2024

Builds ready [51b5d22]
Page Load Metrics (1692 ± 78 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15332327169415976
domContentLoaded15252197166713565
load15342340169216378
domInteractive155528105
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Sep 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Sep 2, 2024

Builds ready [c9ce5d4]
Page Load Metrics (1677 ± 102 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint148625251680212102
domContentLoaded14662470165720297
load147525291677213102
domInteractive127232157
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@pnarayanaswamy pnarayanaswamy merged commit e44420e into develop Sep 4, 2024
@pnarayanaswamy pnarayanaswamy deleted the no-gas-alert-it branch September 4, 2024 09:07
@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 4, 2024
@gauthierpetetin gauthierpetetin added release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jpuri jpuri jpuri approved these changes

@OGPoyraz OGPoyraz OGPoyraz approved these changes

Assignees

No one assigned

Labels

release-12.5.0 Issue or pull request that will be included in release 12.5.0 team-confirmations Push issues to confirmations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pnarayanaswamy @metamaskbot @jpuri @OGPoyraz @gauthierpetetin