Skip to content

feat: new basic functionality event#26837

Merged
matteoscurati merged 6 commits intodevelopfrom
feat/new-basic-functionality-event
Sep 4, 2024
Merged

feat: new basic functionality event#26837
matteoscurati merged 6 commits intodevelopfrom
feat/new-basic-functionality-event

Conversation

@matteoscurati
Copy link
Copy Markdown
Contributor

@matteoscurati matteoscurati commented Sep 2, 2024 •
edited by github-actions bot
Loading

Description

This PR introduces an event to track the use or non-use of basic functionality. This event was introduced to allow tracking of the status of features—like notifications—that depend on external services and need to be turned off if the user decides not to use the basic features.

Open in GitHub Codespaces

Related issues

N/A

Manual testing steps

You can follow the standard procedure for testing the events as described in the README.

Screenshots/Recordings

N/A

Before

N/A

After

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@matteoscurati matteoscurati added the team-notifications-deprecated DEPRECATED: please use "team-assets" instead label Sep 2, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 2, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@matteoscurati matteoscurati changed the title Feat: new basic functionality event feat: new basic functionality event Sep 2, 2024
@matteoscurati matteoscurati marked this pull request as ready for review September 2, 2024 08:13
@matteoscurati matteoscurati requested a review from a team as a code owner September 2, 2024 08:13
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Sep 2, 2024

Builds ready [e36043c]
Page Load Metrics (1847 ± 60 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint24520861689495237
domContentLoaded15852074181612560
load16462089184712660
domInteractive17142503115
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 1.78 KiB (0.02%)
  • common: 0 Bytes (0.00%)

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 70.14%. Comparing base (e44420e) to head (9f3d72b).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...-configuration-modal/basic-configuration-modal.tsx 0.00% 7 Missing ⚠️
...boarding-flow/privacy-settings/privacy-settings.js 0.00% 1 Missing ⚠️
...es/settings/security-tab/security-tab.component.js 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #26837      +/-   ##
===========================================
- Coverage    70.15%   70.14%   -0.01%     
===========================================
  Files         1425     1425              
  Lines        49600    49609       +9     
  Branches     13877    13879       +2     
===========================================
  Hits         34795    34795              
- Misses       14805    14814       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Sep 2, 2024

Builds ready [521d831]
Page Load Metrics (1752 ± 114 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint23926751623517248
domContentLoaded153524901731216104
load154126061752238114
domInteractive118339199
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 1.78 KiB (0.02%)
  • common: 0 Bytes (0.00%)

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Sep 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Sep 4, 2024

Builds ready [9f3d72b]
Page Load Metrics (1782 ± 69 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint25420811637476229
domContentLoaded15682029176313464
load15792085178214369
domInteractive136638168
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 1.78 KiB (0.02%)
  • common: 0 Bytes (0.00%)

@matteoscurati matteoscurati merged commit 31f7ef6 into develop Sep 4, 2024
@matteoscurati matteoscurati deleted the feat/new-basic-functionality-event branch September 4, 2024 10:28
@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 4, 2024
@gauthierpetetin gauthierpetetin added release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chakra-guy chakra-guy chakra-guy approved these changes

@oilnam oilnam oilnam approved these changes

@Prithpal-Sooriya Prithpal-Sooriya Prithpal-Sooriya approved these changes

Assignees

No one assigned

Labels

release-12.5.0 Issue or pull request that will be included in release 12.5.0 team-notifications-deprecated DEPRECATED: please use "team-assets" instead

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@matteoscurati @metamaskbot @chakra-guy @oilnam @Prithpal-Sooriya @gauthierpetetin