fix: Swaps UI should show POL not MATIC#26827
Merged
Gudahtt merged 1 commit intoVersion-v12.1.1from Aug 30, 2024
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Gudahtt
reviewed
Aug 30, 2024
| @@ -70,8 +70,8 @@ export const BNB_SWAPS_TOKEN_OBJECT: SwapsTokenObject = { | |||
| } as const; | |||
|
|
|||
| export const MATIC_SWAPS_TOKEN_OBJECT: SwapsTokenObject = { | |||
Member
There was a problem hiding this comment.
Maybe we can re-name this variable too in a follow-up PR (no need to back port the rename though)
Member
|
I tested this and was able to fetch quotes for both MATIC and POL. Both still appear in the list. Edit: Oh, the MATIC entry is probably the Ethereum token contract. Hmm. Edit2: Confirmed, only POL is showing as the native currency on Polygon, but MATIC and POL contracts are available for swaps on Ethereum Mainnnet. Working as expected. |
Collaborator
Builds ready [bbf21a1]
Page Load Metrics (172 ± 187 ms)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist