Skip to content

fix: Update Swaps symbol from matic to pol#26826

Merged
Gudahtt merged 1 commit intodevelopfrom
fix/swaps-MATIC-POL
Aug 30, 2024
Merged

fix: Update Swaps symbol from matic to pol#26826
Gudahtt merged 1 commit intodevelopfrom
fix/swaps-MATIC-POL

Conversation

@gambinish
Copy link
Copy Markdown
Member

@gambinish gambinish commented Aug 30, 2024 •
edited by infiniteflower
Loading

Description

Updates MATIC to POL in swaps UI

Related issues

Fixes:

Manual testing steps

  1. Go to this page

Go to swaps screen for POL token, token should be POL not MATIC

Screenshots/Recordings

Screenshot 2024-08-30 at 12 28 52 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@gambinish gambinish marked this pull request as ready for review August 30, 2024 19:29
@gambinish gambinish requested a review from a team as a code owner August 30, 2024 19:29
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 30, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gambinish gambinish requested a review from Gudahtt August 30, 2024 19:30
@gambinish gambinish changed the title Update Swaps symbol from matic to pol fix: Update Swaps symbol from matic to pol Aug 30, 2024
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Aug 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Gudahtt
Gudahtt approved these changes Aug 30, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Aug 30, 2024

Builds ready [20bae32]
Page Load Metrics (1593 ± 67 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint13620541402518249
domContentLoaded14302046158213967
load14322055159314067
domInteractive119728188
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.13%. Comparing base (7bf8ffc) to head (20bae32).

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #26826   +/-   ##
========================================
  Coverage    70.13%   70.13%           
========================================
  Files         1417     1417           
  Lines        49444    49444           
  Branches     13835    13835           
========================================
+ Hits         34675    34676    +1     
+ Misses       14769    14768    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gudahtt Gudahtt merged commit 0d971b9 into develop Aug 30, 2024
@Gudahtt Gudahtt deleted the fix/swaps-MATIC-POL branch August 30, 2024 20:17
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Aug 30, 2024
@gauthierpetetin gauthierpetetin added release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@infiniteflower infiniteflower infiniteflower approved these changes

Assignees

No one assigned

Labels

release-12.5.0 Issue or pull request that will be included in release 12.5.0 team-assets

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gambinish @metamaskbot @Gudahtt @infiniteflower @gauthierpetetin