fix: update notifications events by matteoscurati · Pull Request #26807 · MetaMask/metamask-extension

matteoscurati · 2024-08-30T12:00:43Z

Description

This PR updates or corrects the events related to notifications. The events have also been updated in the Segment repository.

Related issues

Fixes:

Manual testing steps

To test these new events, you can follow the standard procedure outlined in the README file.

Screenshots/Recordings

N/A

Before

N/A

After

N/A

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-08-30T12:00:59Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

codecov · 2024-09-02T13:12:59Z

Codecov Report

Attention: Patch coverage is 83.33333% with 10 lines in your changes missing coverage. Please review.

Project coverage is 70.16%. Comparing base (3e68e38) to head (cc9f2b7).
Report is 3 commits behind head on develop.

Files with missing lines	Patch %	Lines
...il-network-fee/notification-detail-network-fee.tsx	0.00%	3 Missing ⚠️
...il-copy-button/notification-detail-copy-button.tsx	80.00%	2 Missing ⚠️
...s/metamask-notifications/metamask-notifications.ts	85.71%	2 Missing ⚠️
...i/components/multichain/global-menu/global-menu.js	66.67%	1 Missing ⚠️
...ications-tag-counter/notifications-tag-counter.tsx	75.00%	1 Missing ⚠️
ui/hooks/metamask-notifications/useCounter.tsx	95.45%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #26807      +/-   ##
===========================================
+ Coverage    70.15%   70.16%   +0.01%     
===========================================
  Files         1425     1425              
  Lines        49600    49637      +37     
  Branches     13877    13889      +12     
===========================================
+ Hits         34795    34826      +31     
- Misses       14805    14811       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2024-09-02T13:23:56Z

Builds ready [f52738f]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2076 ± 131 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	266	2607	1773	670	322
		domContentLoaded	1664	2530	2046	263	126
		load	1672	2536	2076	272	131
		domInteractive	24	142	51	30	14

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -60 Bytes (-0.00%)
ui: 2.9 KiB (0.04%)
common: 360 Bytes (0.00%)

metamaskbot · 2024-09-02T14:51:21Z

Builds ready [61da198]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1775 ± 74 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	229	2298	1707	374	179
		domContentLoaded	1595	2247	1749	146	70
		load	1607	2257	1775	154	74
		domInteractive	13	148	37	28	13

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -60 Bytes (-0.00%)
ui: 2.9 KiB (0.04%)
common: 360 Bytes (0.00%)

metamaskbot · 2024-09-03T16:34:55Z

Builds ready [6141fe8]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1789 ± 121 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	190	2665	1579	620	298
		domContentLoaded	1542	2648	1768	242	116
		load	1547	2657	1789	251	121
		domInteractive	24	140	41	25	12

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -60 Bytes (-0.00%)
ui: 2.9 KiB (0.04%)
common: 360 Bytes (0.00%)

metamaskbot · 2024-09-03T18:26:50Z

Builds ready [0974ed7]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1768 ± 50 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	217	2073	1622	474	227
		domContentLoaded	1593	1992	1745	98	47
		load	1602	2079	1768	105	50
		domInteractive	12	55	31	12	6

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -60 Bytes (-0.00%)
ui: 2.9 KiB (0.04%)
common: 362 Bytes (0.00%)

metamaskbot · 2024-09-03T20:30:05Z

Builds ready [1129ded]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1821 ± 55 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	239	2099	1688	483	232
		domContentLoaded	1596	2006	1807	114	55
		load	1599	2017	1821	115	55
		domInteractive	13	60	34	13	6

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -60 Bytes (-0.00%)
ui: 2.88 KiB (0.04%)
common: 362 Bytes (0.00%)

metamaskbot · 2024-09-04T09:59:22Z

Builds ready [b5ea8cd]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1898 ± 87 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	262	2320	1716	505	243
		domContentLoaded	1564	2345	1878	182	87
		load	1573	2356	1898	182	87
		domInteractive	23	64	37	12	6

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -60 Bytes (-0.00%)
ui: 2.88 KiB (0.04%)
common: 362 Bytes (0.00%)

sonarqubecloud · 2024-09-04T10:11:09Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.1% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-09-04T10:44:01Z

Builds ready [cc9f2b7]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1650 ± 58 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	218	2066	1583	335	161
		domContentLoaded	1506	1944	1624	98	47
		load	1514	2077	1650	122	58
		domInteractive	21	91	38	18	9

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -60 Bytes (-0.00%)
ui: 2.88 KiB (0.04%)
common: 362 Bytes (0.00%)

matteoscurati added 10 commits August 28, 2024 16:22

fix: 🐛 remove is_signed_in property

628b937

fix: 🐛 update settings update event in the onboarding flow

fb7a95d

fix: 🐛 remove duplicated event

f885fce

fix: 🏷️ update a label

e0eacc2

fix: 🐛 fix menu event

1cccfdb

fix: 🐛 fix notification clicked event

0cd694d

fix: 🐛 fix notification detail clicked events

6d203b3

fix: 🐛 fix push notifications events

b4bcfa8

fix: 🐛 fix notifications settings events

a9cb358

fix: 🐛 fix settings update event

0e4ff2f

matteoscurati added the team-notifications-deprecated DEPRECATED: please use "team-assets" instead label Aug 30, 2024

matteoscurati changed the title ~~Fix/update notifications events~~ fix: update notifications events Aug 30, 2024

Merge branch 'develop' into fix/update-notifications-events

f2325a7

matteoscurati marked this pull request as ready for review August 30, 2024 12:16

matteoscurati requested review from a team as code owners August 30, 2024 12:16

matteoscurati added 5 commits September 2, 2024 10:27

Merge branch 'develop' into fix/update-notifications-events

39d0967

test: ✅ fix wallet created tests

9617a1e

Merge branch 'develop' into fix/update-notifications-events

d7f1714

fix: ✅ fix tests

a8b0511

Merge branch 'develop' into fix/update-notifications-events

f52738f

Merge branch 'develop' into fix/update-notifications-events

61da198

Prithpal-Sooriya previously approved these changes Sep 3, 2024

View reviewed changes

Merge branch 'develop' into fix/update-notifications-events

6141fe8

oilnam approved these changes Sep 3, 2024

View reviewed changes

fix: 🏷️ fix typo

0974ed7

matteoscurati dismissed Prithpal-Sooriya’s stale review via 0974ed7 September 3, 2024 17:53

matteoscurati added 3 commits September 3, 2024 21:25

fix: 🐛 fix notification-detail event

81eedda

fix: 🐛 fix notification clicked events

496baeb

fix: 🏷️ typo

1129ded

Prithpal-Sooriya previously approved these changes Sep 4, 2024

View reviewed changes

chakra-guy previously approved these changes Sep 4, 2024

View reviewed changes

matteoscurati added 2 commits September 4, 2024 11:03

Merge branch 'develop' into fix/update-notifications-events

8d39c71

feat: 🏷️ fix typo

49c6b2a

matteoscurati dismissed stale reviews from Prithpal-Sooriya and chakra-guy via 49c6b2a September 4, 2024 09:12

Merge branch 'develop' into fix/update-notifications-events

b5ea8cd

chakra-guy approved these changes Sep 4, 2024

View reviewed changes

Merge branch 'develop' into fix/update-notifications-events

cc9f2b7

Prithpal-Sooriya approved these changes Sep 4, 2024

View reviewed changes

matteoscurati merged commit 44cf6ac into develop Sep 4, 2024

matteoscurati deleted the fix/update-notifications-events branch September 4, 2024 10:50

github-actions bot locked and limited conversation to collaborators Sep 4, 2024

metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 4, 2024

gauthierpetetin added release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Sep 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: update notifications events#26807

fix: update notifications events#26807
matteoscurati merged 26 commits intodevelopfrom
fix/update-notifications-events

matteoscurati commented Aug 30, 2024 •

edited by github-actions bot

Loading

Uh oh!

github-actions bot commented Aug 30, 2024

Uh oh!

codecov bot commented Sep 2, 2024 •

edited

Loading

Uh oh!

metamaskbot commented Sep 2, 2024

Uh oh!

metamaskbot commented Sep 2, 2024

Uh oh!

metamaskbot commented Sep 3, 2024

Uh oh!

metamaskbot commented Sep 3, 2024

Uh oh!

metamaskbot commented Sep 3, 2024

Uh oh!

metamaskbot commented Sep 4, 2024

Uh oh!

sonarqubecloud bot commented Sep 4, 2024

Uh oh!

metamaskbot commented Sep 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

matteoscurati commented Aug 30, 2024 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Aug 30, 2024

Uh oh!

codecov bot commented Sep 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

metamaskbot commented Sep 2, 2024

Uh oh!

metamaskbot commented Sep 2, 2024

Uh oh!

metamaskbot commented Sep 3, 2024

Uh oh!

metamaskbot commented Sep 3, 2024

Uh oh!

metamaskbot commented Sep 3, 2024

Uh oh!

metamaskbot commented Sep 4, 2024

Uh oh!

sonarqubecloud bot commented Sep 4, 2024

Quality Gate passed

Uh oh!

metamaskbot commented Sep 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

matteoscurati commented Aug 30, 2024 •

edited by github-actions bot

Loading

codecov bot commented Sep 2, 2024 •

edited

Loading