Description

There is a race condition which happens when we trigger a Send from Dapp 1 (Localhost 7777) and quickly switch to Dapp 0 (Localhost 8545) and trigger a Sign there.

What happens is that the network for the first Send, is taken for the one on Dapp 0 (localhost 8545), so when we try to find the correct network (7777) in the Send screen fails (see artifacts below).

// Check correct network on the send confirmation.
        await driver.findElement({
          css: '[data-testid="network-display"]',
          text: 'Localhost 7777',
        });

To mitigate this race condition, after we trigger the Send from Dapp 1 (Localhost 7777) we wait until the popup is open and then switch to Dapp 0 and proceed with the Sign action (Localhost 8545).

Related issues

Fixes: #26795

Manual testing steps

1. Check ci
2. Run test locally in webpack build yarn test:e2e:single test/e2e/tests/request-queuing/dapp1-send-dapp2-signTypedData.spec.js --browser=chrome --retries=10 --stop-after-one-failure=true

Screenshots/Recordings

Notice the Send has Localhost 8545, but it should be Localhost 7777

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.