fix: flaky test Test Snap Interactive UI test interactive ui elements#26792
Merged
fix: flaky test Test Snap Interactive UI test interactive ui elements#26792
Test Snap Interactive UI test interactive ui elements#26792Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #26792 +/- ##
========================================
Coverage 70.13% 70.13%
========================================
Files 1417 1417
Lines 49440 49440
Branches 13833 13833
========================================
Hits 34672 34672
Misses 14768 14768 ☔ View full report in Codecov by Sentry. |
FrederikBolding
approved these changes
Aug 30, 2024
Collaborator
Builds ready [faff3ab]
Page Load Metrics (1762 ± 101 ms)
Bundle size diffs
|
chloeYue
approved these changes
Aug 30, 2024
Contributor
chloeYue
left a comment
There was a problem hiding this comment.
LGTM ! Thanks for the fix !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The snap fails at the point of trying to find the scrolll element. The problem is that the previous
Connectaction takes several seconds, and the default timeout for the next action is not enough (1000ms) -- see video.In this PR we increase the timeout to 3000ms.
Note: having a bigger timeout is safe, as if the condition is met earlier, it will jump to the next step, so we won't wait for the complete 3000ms when it's not needed.
Related issues
Fixes: #26793
Manual testing steps
Screenshots/Recordings
See how the Connect action takes some time, making the subsequent action to fail, as the scroll element cannot be located within the timeout
snap-failure-scroll.mp4
Pre-merge author checklist
Pre-merge reviewer checklist