Skip to content

fix: PermitTransferFrom or PermitBatchTransferFrom crashes MM when value for Name address has not been loaded #26791

Merged
digiwand merged 2 commits intodevelopfrom
fix-confirm-name-no-0x-prefix-value
Aug 30, 2024
Merged

fix: PermitTransferFrom or PermitBatchTransferFrom crashes MM when value for Name address has not been loaded #26791
digiwand merged 2 commits intodevelopfrom
fix-confirm-name-no-0x-prefix-value

Conversation

@digiwand
Copy link
Copy Markdown
Contributor

@digiwand digiwand commented Aug 30, 2024 •
edited
Loading

Description

Open in GitHub Codespaces

Related issues

Fixes: #26593
Related Cherry-pick: #27168

V12.3.0 cherry-pick Fixes: #26830

Manual testing steps

See issue ticket

Screenshots/Recordings

Before

breaking app

After

no longer breaking app

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@digiwand digiwand requested a review from a team as a code owner August 30, 2024 03:44
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 30, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-confirmations Push issues to confirmations team label Aug 30, 2024
@digiwand digiwand added type-bug Something isn't working and removed team-confirmations Push issues to confirmations team labels Aug 30, 2024
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Aug 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@digiwand digiwand added the team-confirmations Push issues to confirmations team label Aug 30, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.13%. Comparing base (1b4417d) to head (07a85e8).

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #26791   +/-   ##
========================================
  Coverage    70.13%   70.13%           
========================================
  Files         1417     1417           
  Lines        49440    49444    +4     
  Branches     13833    13835    +2     
========================================
+ Hits         34672    34676    +4     
  Misses       14768    14768

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Aug 30, 2024

Builds ready [07a85e8]
Page Load Metrics (1965 ± 114 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint25327581876440211
domContentLoaded160326061935210101
load161227671965237114
domInteractive14123422512
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 32 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@digiwand digiwand merged commit 0490020 into develop Aug 30, 2024
@digiwand digiwand deleted the fix-confirm-name-no-0x-prefix-value branch August 30, 2024 13:19
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Aug 30, 2024
@gauthierpetetin gauthierpetetin added release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Sep 11, 2024
@digiwand digiwand added release-12.3.0 Issue or pull request that will be included in release 12.3.0 and removed release-12.5.0 Issue or pull request that will be included in release 12.5.0 labels Sep 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jpuri jpuri jpuri approved these changes

@matthewwalsh0 matthewwalsh0 matthewwalsh0 approved these changes

Assignees

No one assigned

Labels

release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-confirmations Push issues to confirmations team type-bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cherry-pick PRs for 12.3.0 (including formal 12.4.0 PRs) [Bug]: MM crashes with a PermitTransferFrom or PermitBatchTransferFrom signature request

5 participants

@digiwand @metamaskbot @jpuri @matthewwalsh0 @gauthierpetetin