fix: Cherry pick 1b4417d for 12.1.1#26780
Merged
gambinish merged 4 commits intoVersion-v12.1.1from Aug 30, 2024
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
1b4417d for 12.1.1
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## Version-v12.1.1 #26780 +/- ##
===================================================
+ Coverage 69.84% 69.86% +0.03%
===================================================
Files 1371 1372 +1
Lines 48791 48835 +44
Branches 13453 13484 +31
===================================================
+ Hits 34074 34118 +44
Misses 14717 14717 ☔ View full report in Codecov by Sentry. |
Collaborator
Builds ready [8d7acc1]
Page Load Metrics (332 ± 306 ms)
|
chloeYue
approved these changes
Aug 30, 2024
Gudahtt
previously requested changes
Aug 30, 2024
Member
Gudahtt
left a comment
There was a problem hiding this comment.
I'm seeing one more reference to MATIC in app/scripts/controllers/metamask-notifications/constants/notification-schema.ts. Looks like this should be updated to POL as well. This wasn't included in the change we landed on develop because the file doesn't exist there.
Collaborator
Builds ready [a131703]
Page Load Metrics (595 ± 496 ms)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backports changes from MATIC - POL update, including state migration: #26671
Related issues
Fixes: MATIC ticker should now be POL. Should automatically update for users.
Manual testing steps
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist