docs: Manual scenario for "Import account with private key" feature#26756
docs: Manual scenario for "Import account with private key" feature#26756benjisclowder merged 5 commits intodevelopfrom
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #26756 +/- ##
========================================
Coverage 70.13% 70.13%
========================================
Files 1424 1424
Lines 49571 49571
Branches 13867 13867
========================================
Hits 34765 34765
Misses 14806 14806 ☔ View full report in Codecov by Sentry. |
Builds ready [1d3527e]
Page Load Metrics (1872 ± 134 ms)
Bundle size diffs
|
|
For information, i changed PR title from |
Thank you, Chloe! |
Builds ready [1d9770f]
Page Load Metrics (1636 ± 51 ms)
Bundle size diffs
|
|
|
||
| Given I am on the 'Import account' menu | ||
| When I select 'Import account' | ||
| Then I should be directed to the Import page |
There was a problem hiding this comment.
Then I should be directed to the import dialog modal.
There was a problem hiding this comment.
@hjetpoluru I have now modified the duplicates and the other mention, although I am not sure we are supposed to provide private keys. I will add and ask @chloeYue for an opinion as well?
There was a problem hiding this comment.
while i checked a bit in the official doc, we sometimes provide the private key example and sometimes not, so either way is OK for me.
https://support.metamask.io/managing-my-wallet/secret-recovery-phrase-and-private-keys/how-to-export-an-accounts-private-key/
https://support.metamask.io/managing-my-wallet/accounts-and-addresses/how-to-import-an-account
| Given I am on the 'Import account' menu | ||
| When I select 'Import account' | ||
| Then I should be directed to the Import page | ||
| And I should see a field to paste my private key |
There was a problem hiding this comment.
Could you provide example private key.
|
@benjisclowder, overall manual scenario is good. I've provided a few minor review comments. |
|
|
||
| Given I am on the import dialog modal | ||
| When I see a field to paste my private key | ||
| And I paste my private key (e.g.: 669456835741782c2ceca4e6ded60420ede38db2fb28742a1c9ae5ddf6680fa9) and click 'Import' |
There was a problem hiding this comment.
Thanks @benjisclowder for updating. I wanted to provide below sample example, current format is good too.
| field | value |
| private key | 669456835741782c2ceca4e6ded60420ede38db2fb28742a1c9ae5ddf6680fa9 |
There was a problem hiding this comment.
I will leave it in the current format, but I would like to understand how the format you proposed works as well in a scenario, where you would place it, @hjetpoluru.
However, the test is now in a final format and I would appreciate your final review. Thank you!
There was a problem hiding this comment.
yeah that sounds good, given we will be soon moving to TestRail too which will make editing definitely easy. It would be bottom of the test step itself.
Given I am on the import dialog modal
When I see a field to paste my private key
And I paste my private key and click 'Import'
| field | value |
| private key | 669456835741782c2ceca4e6ded60420ede38db2fb28742a1c9ae5ddf6680fa9 |
Then I should see the newly imported account in the account selector dropdown
And the newly imported account should have an 'Imported' tag next to it
|
Builds ready [f658f6b]
Page Load Metrics (1714 ± 98 ms)
Bundle size diffs
|
Description
This PR documents the manual test scenario for the 'Import account with private key' feature. Below is a summary of the validations included in this manual scenario:
Related issues
Fixes: #22006
Manual testing steps
--> test/manual-scenarios/keyring/import account using private key.md
Rendered view of the manual scenario - https://github.com/MetaMask/metamask-extension/blob/import-account-with-private-key-scenario/test/manual-scenarios/keyring/import%20account%20using%20private%20key.md