fix: rename migration 126 to 121.1#26742
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
Builds ready [262dc2e]
Page Load Metrics (1866 ± 93 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #26742 +/- ##
========================================
Coverage 70.08% 70.08%
========================================
Files 1414 1414
Lines 49330 49330
Branches 13781 13782 +1
========================================
Hits 34570 34570
Misses 14760 14760 ☔ View full report in Codecov by Sentry. |
262dc2e to
753e93c
Compare
gantunesr
previously approved these changes
Aug 29, 2024
Collaborator
Builds ready [753e93c]
Page Load Metrics (1811 ± 80 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Gudahtt
reviewed
Aug 29, 2024
Gudahtt
requested changes
Aug 29, 2024
Member
Gudahtt
left a comment
There was a problem hiding this comment.
I found one minor issue, a reference to the old migration number.
Aside from that, this looks good to me! I found a few more problems with the original migration, but I will work on proposing changes in a separate PR. It would be easiest to just re-number things here, adding functional changes would make the git history confusing.
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
|
Gudahtt
approved these changes
Aug 29, 2024
Collaborator
Builds ready [07c9720]
Page Load Metrics (1705 ± 69 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
gantunesr
approved these changes
Aug 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR renames migration 126 to 121.1. The reason for this renaming is that commit 759b92e is being cherry-picked into version 12.1.1.
Between version 12.1.1 and the develop branch, there are missing migrations. To avoid skipping these migrations in subsequent releases, we need to rename migration 126 to 121.1.
Related issues
Related: #26377
Manual testing steps
N/a
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist