fix: Stop using a hardcoded Snap ID for notifications#26739
Merged
FrederikBolding merged 1 commit intodevelopfrom Aug 29, 2024
Merged
fix: Stop using a hardcoded Snap ID for notifications#26739FrederikBolding merged 1 commit intodevelopfrom
FrederikBolding merged 1 commit intodevelopfrom
Conversation
|
Prithpal-Sooriya
approved these changes
Aug 29, 2024
david0xd
approved these changes
Aug 29, 2024
Mrtenz
approved these changes
Aug 29, 2024
Collaborator
Builds ready [68755eb]
Page Load Metrics (1728 ± 69 ms)
Bundle size diffs
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a mistake not caught during review where
NotificationListItemSnapuses a hardcoded example Snap ID for the icon of all Snaps.