Skip to content

chore: MMI Fixes passing the state to route using history.push#26722

Merged
zone-live merged 3 commits intodevelopfrom
MMI-5456-interactive-token-replacement-flow-breaks
Aug 29, 2024
Merged

chore: MMI Fixes passing the state to route using history.push#26722
zone-live merged 3 commits intodevelopfrom
MMI-5456-interactive-token-replacement-flow-breaks

Conversation

@zone-live
Copy link
Copy Markdown
Contributor

Description

Passing the state to route using history.push in order to get these values in the final view.
They were not arriving before.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@zone-live zone-live added the mmi DEPRECATED: The product got sunset label Aug 28, 2024
@zone-live zone-live requested a review from a team as a code owner August 28, 2024 15:00
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@zone-live zone-live requested a review from a team as a code owner August 29, 2024 08:49
@sonarqubecloud
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.08%. Comparing base (c3069ee) to head (4e870c4).
Report is 12 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #26722      +/-   ##
===========================================
+ Coverage    70.05%   70.08%   +0.03%     
===========================================
  Files         1414     1414              
  Lines        49317    49330      +13     
  Branches     13780    13781       +1     
===========================================
+ Hits         34546    34570      +24     
+ Misses       14771    14760      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [4e870c4]
Page Load Metrics (102 ± 23 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint703411346129
domContentLoaded54252994823
load542531024823
domInteractive12129352512
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@zone-live zone-live merged commit 690deb4 into develop Aug 29, 2024
@zone-live zone-live deleted the MMI-5456-interactive-token-replacement-flow-breaks branch August 29, 2024 10:45
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2024
@metamaskbot metamaskbot added the release-12.5.0 Issue or pull request that will be included in release 12.5.0 label Aug 29, 2024
@gauthierpetetin gauthierpetetin added release-12.4.0 Issue or pull request that will be included in release 12.4.0 and removed release-12.5.0 Issue or pull request that will be included in release 12.5.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

mmi DEPRECATED: The product got sunset release-12.4.0 Issue or pull request that will be included in release 12.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants