Skip to content

test: Add integration test for insufficient gas#26711

Merged
pnarayanaswamy merged 5 commits intodevelopfrom
gas-too-low-it-test
Aug 29, 2024
Merged

test: Add integration test for insufficient gas#26711
pnarayanaswamy merged 5 commits intodevelopfrom
gas-too-low-it-test

Conversation

@pnarayanaswamy
Copy link
Copy Markdown
Contributor

@pnarayanaswamy pnarayanaswamy commented Aug 28, 2024 •
edited
Loading

Description

Adds integration test for checking insufficient gas alert

Open in GitHub Codespaces

Related issues

Fixes: #2976

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 28, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-confirmations Push issues to confirmations team label Aug 28, 2024
@pnarayanaswamy pnarayanaswamy changed the title Gas too low it test test: Add integration test for insufficient gas Aug 28, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.08%. Comparing base (2f30256) to head (80e4408).
Report is 2 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #26711   +/-   ##
========================================
  Coverage    70.08%   70.08%           
========================================
  Files         1414     1414           
  Lines        49327    49328    +1     
  Branches     13781    13781           
========================================
+ Hits         34567    34568    +1     
  Misses       14760    14760

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Aug 28, 2024

Builds ready [1225985]
Page Load Metrics (139 ± 26 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint823281775928
domContentLoaded602381334924
load662711395526
domInteractive19139603316
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 72 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@pnarayanaswamy pnarayanaswamy marked this pull request as ready for review August 29, 2024 06:34
@pnarayanaswamy pnarayanaswamy requested a review from a team as a code owner August 29, 2024 06:34
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Aug 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Aug 29, 2024

Builds ready [80e4408]
Page Load Metrics (1614 ± 67 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint23920731483410197
domContentLoaded14422033159813263
load14502074161413967
domInteractive177430147
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 44 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@pnarayanaswamy pnarayanaswamy merged commit f354888 into develop Aug 29, 2024
@pnarayanaswamy pnarayanaswamy deleted the gas-too-low-it-test branch August 29, 2024 07:53
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2024
@metamaskbot metamaskbot added the release-12.5.0 Issue or pull request that will be included in release 12.5.0 label Aug 29, 2024
@gauthierpetetin gauthierpetetin added release-12.4.0 Issue or pull request that will be included in release 12.4.0 and removed release-12.5.0 Issue or pull request that will be included in release 12.5.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jpuri jpuri jpuri approved these changes

@vinistevam vinistevam vinistevam approved these changes

Assignees

No one assigned

Labels

release-12.4.0 Issue or pull request that will be included in release 12.4.0 team-confirmations Push issues to confirmations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pnarayanaswamy @metamaskbot @jpuri @vinistevam @gauthierpetetin