test: add spec Vault decrypt - paste encrypted vault into field#26678
test: add spec Vault decrypt - paste encrypted vault into field#26678
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
|
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat's wrong with native code?Contains native code which could be a vector to obscure malicious code, and generally decrease the likelihood of reproducible or reliable installs. Ensure that native code bindings are expected. Consumers may consider pure JS and functionally similar alternatives to avoid the challenges and risks associated with native code bindings. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
|
| "analytics-node/axios": "^0.21.2", | ||
| "bn.js": "^5.2.1", | ||
| "ganache-core/lodash": "^4.17.21", | ||
| "ganache/abstract-level": "1.0.4", |
There was a problem hiding this comment.
added this entry in the resolutions as per this suggestion from @legobeat
#26612 (comment)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #26678 +/- ##
========================================
Coverage 70.09% 70.09%
========================================
Files 1413 1413
Lines 49255 49255
Branches 13768 13768
========================================
Hits 34524 34524
Misses 14731 14731 ☔ View full report in Codecov by Sentry. |
Builds ready [56be2d9]
Page Load Metrics (93 ± 50 ms)
Bundle size diffs
|
Description
This PR adds a new spec for testing the flow for pasting the encrypted vault into the vault decryptor page. This was suggested by @davidmurdoch which also provided the logic for the implementation 🙇♀️ .
At the moment, we were only testing the upload file functionality. Now we test both the upload file, and the paste into the field.
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3081
Manual testing steps
yarn dist&&yarn test:e2e:single test/e2e/vault-decryption-chrome.spec.js --browser=chrome --leave-running=trueScreenshots/Recordings
paste-vault-into-field.mp4
Pre-merge author checklist
Pre-merge reviewer checklist