feat: Adding context to get current confirmation PR-5 by jpuri · Pull Request #26673 · MetaMask/metamask-extension

jpuri · 2024-08-27T04:40:56Z

Description

Using context to get currently selected confirmation in re-designed confirmation pages. This is done to switch to using react context transient UI state in re-designed confirmation pages.

Related issues

Ref: #26414

Manual testing steps

NA

Screenshots/Recordings

NA

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…Context

github-actions · 2024-08-27T04:41:12Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

codecov · 2024-08-27T05:29:54Z

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.14%. Comparing base (851db4c) to head (3919c1a).
Report is 5 commits behind head on develop.

Files with missing lines	Patch %	Lines
...ations/components/confirm/info/approve/approve.tsx	50.00%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #26673   +/-   ##
========================================
  Coverage    70.14%   70.14%           
========================================
  Files         1424     1424           
  Lines        49572    49573    +1     
  Branches     13868    13868           
========================================
+ Hits         34769    34771    +2     
+ Misses       14803    14802    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2024-08-27T05:41:41Z

Builds ready [60d19ee]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (94 ± 10 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	82	166	125	25	12
		domContentLoaded	50	133	92	24	11
		load	56	133	94	22	10
		domInteractive	12	58	35	13	6

Bundle size diffs [🚀 Bundle size reduced!]

background: 0 Bytes (0.00%)
ui: 3.06 KiB (0.04%)
common: -461 Bytes (-0.01%)

metamaskbot · 2024-08-27T14:52:15Z

Builds ready [e85595c]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (112 ± 15 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	92	230	142	37	18
		domContentLoaded	71	171	109	29	14
		load	72	186	112	32	15
		domInteractive	23	83	41	17	8

Bundle size diffs [🚀 Bundle size reduced!]

background: 0 Bytes (0.00%)
ui: 3.02 KiB (0.04%)
common: -461 Bytes (-0.01%)

The base branch was changed.

metamaskbot · 2024-09-03T15:37:41Z

Builds ready [a7b70ec]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1783 ± 94 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1516	2376	1791	199	95
		domContentLoaded	1510	2287	1764	183	88
		load	1517	2375	1783	196	94
		domInteractive	14	76	36	17	8

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 421 Bytes (0.01%)
common: 0 Bytes (0.00%)

sonarqubecloud · 2024-09-03T15:41:30Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-09-03T16:24:11Z

Builds ready [3919c1a]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1801 ± 118 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	212	2561	1630	493	237
		domContentLoaded	1498	2404	1771	225	108
		load	1537	2588	1801	245	118
		domInteractive	13	98	36	21	10

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 307 Bytes (0.00%)
common: 0 Bytes (0.00%)

jpuri added 22 commits August 22, 2024 21:44

Adding context to get current confirmation

119b0d4

Adding context to get current confirmation

52c9891

update

eb5c1ad

update

392aab8

Merge branch 'confirmation_context' into confirmation_context_2

62da84e

update

61fd4be

update

44d4888

update

c6b35fb

update

d06c812

Merge branch 'develop' into confirmation_context

abce1c3

merge

166ac09

update

aea945a

update

ca38007

update

69d6753

update

7b24f9f

Refactoring confirmation code to use currentConfirmation from confirm…

c6280c2

…Context

Refactoring confirmation code to use currentConfirmation from confirm…

98e95db

…Context

update

7d40fc6

update

59d707a

Merge branch 'confirmation_context_3' into confirmation_context_4

0da890d

update

d7f6945

Refactoring confirmation code to use currentConfirmation from confirm…

60d19ee

…Context

jpuri added the team-confirmations Push issues to confirmations team label Aug 27, 2024

jpuri requested review from a team as code owners August 27, 2024 04:40

update

e85595c

matthewwalsh0 previously approved these changes Aug 29, 2024

View reviewed changes

Base automatically changed from confirmation_context_4 to develop September 3, 2024 14:15

jpuri requested a review from a team as a code owner September 3, 2024 14:15

jpuri added 3 commits September 3, 2024 20:02

merge

bf8c2d6

update

124b1dc

update

a7b70ec

update

3919c1a

jpuri requested a review from matthewwalsh0 September 3, 2024 16:01

matthewwalsh0 approved these changes Sep 3, 2024

View reviewed changes

digiwand approved these changes Sep 4, 2024

View reviewed changes

zone-live approved these changes Sep 4, 2024

View reviewed changes

jpuri merged commit 42adcfd into develop Sep 4, 2024

jpuri deleted the confirmation_context_5 branch September 4, 2024 10:17

github-actions bot locked and limited conversation to collaborators Sep 4, 2024

metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 4, 2024

gauthierpetetin added release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Sep 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Adding context to get current confirmation PR-5#26673

feat: Adding context to get current confirmation PR-5#26673
jpuri merged 27 commits intodevelopfrom
confirmation_context_5

jpuri commented Aug 27, 2024

Uh oh!

github-actions bot commented Aug 27, 2024

Uh oh!

codecov bot commented Aug 27, 2024 •

edited

Loading

Uh oh!

metamaskbot commented Aug 27, 2024

Uh oh!

metamaskbot commented Aug 27, 2024

Uh oh!

metamaskbot commented Sep 3, 2024

Uh oh!

sonarqubecloud bot commented Sep 3, 2024

Uh oh!

metamaskbot commented Sep 3, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

jpuri commented Aug 27, 2024

Description

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Aug 27, 2024

Uh oh!

codecov bot commented Aug 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

metamaskbot commented Aug 27, 2024

Uh oh!

metamaskbot commented Aug 27, 2024

Uh oh!

metamaskbot commented Sep 3, 2024

Uh oh!

sonarqubecloud bot commented Sep 3, 2024

Quality Gate passed

Uh oh!

metamaskbot commented Sep 3, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov bot commented Aug 27, 2024 •

edited

Loading