Skip to content

chore: Remove non-applicable change entries#26663

Merged
Gudahtt merged 1 commit intoVersion-v12.1.0from
v12.1.0-remove-non-applicable-change-entries
Aug 26, 2024
Merged

chore: Remove non-applicable change entries#26663
Gudahtt merged 1 commit intoVersion-v12.1.0from
v12.1.0-remove-non-applicable-change-entries

Conversation

@Gudahtt
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt commented Aug 26, 2024 •
edited
Loading

Description

These change entries are for features that aren't yet enabled. They are behind build flags.

Open in GitHub Codespaces

Related issues

N/A

Manual testing steps

n/A

Screenshots/Recordings

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Gudahtt
chore: Remove non-applicable change entries
621aa4f 
These change entries are for features that aren't yet enabled. They are
behind a build flag.
@Gudahtt Gudahtt added the team-extension-platform Extension Platform team label Aug 26, 2024
@Gudahtt Gudahtt marked this pull request as ready for review August 26, 2024 17:20
@Gudahtt Gudahtt requested a review from a team as a code owner August 26, 2024 17:20
benjisclowder
benjisclowder approved these changes Aug 26, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@benjisclowder benjisclowder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.80%. Comparing base (e5f4f32) to head (621aa4f).

Additional details and impacted files 
@@               Coverage Diff                @@
##           Version-v12.1.0   #26663   +/-   ##
================================================
  Coverage            69.80%   69.80%           
================================================
  Files                 1370     1370           
  Lines                48739    48739           
  Branches             13438    13438           
================================================
  Hits                 34019    34019           
  Misses               14720    14720

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Aug 26, 2024

Builds ready [621aa4f]
Page Load Metrics (73 ± 10 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint681511012010
domContentLoaded115330126
load50124732010
domInteractive115330126

@Gudahtt Gudahtt merged commit 335c9e4 into Version-v12.1.0 Aug 26, 2024
@Gudahtt Gudahtt deleted the v12.1.0-remove-non-applicable-change-entries branch August 26, 2024 18:53
@github-actions github-actions bot locked and limited conversation to collaborators Aug 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@benjisclowder benjisclowder benjisclowder approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

team-extension-platform Extension Platform team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Gudahtt @metamaskbot @benjisclowder