Skip to content

fix(snaps): Use ApprovalType instead DIALOG_APPROVAL_TYPES in confirmation page#26655

Merged
ritave merged 4 commits intodevelopfrom
ritave/approval-type
Aug 27, 2024
Merged

fix(snaps): Use ApprovalType instead DIALOG_APPROVAL_TYPES in confirmation page#26655
ritave merged 4 commits intodevelopfrom
ritave/approval-type

Conversation

@ritave
Copy link
Copy Markdown
Contributor

@ritave ritave commented Aug 26, 2024 •
edited by github-actions Bot
Loading

Description

This PR uses proper constant from ApprovalType instead of DIALOG_APPROVAL_TYPES.

This required updating @metamask/controller-utils to ^11.1.0. I manually reviewed all breaking changes from controller-utils and found no breakages in the metamask-extension.

Open in GitHub Codespaces

Related issues

Fixes MetaMask/core#4598

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@ritave ritave added team-snaps-platform-deprecated DEPRECATED: please use "team-core-platform" instead (or "team-new-networks" for Solana snap issues) team-confirmations Push issues to confirmations team labels Aug 26, 2024
@socket-security
Copy link
Copy Markdown

socket-security Bot commented Aug 26, 2024 •
edited
Loading

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/@metamask/controller-utils@10.0.0)

View full report↗︎

Mrtenz
Mrtenz previously approved these changes Aug 26, 2024
View reviewed changes
@ritave
Copy link
Copy Markdown
Contributor Author

ritave commented Aug 26, 2024

@metamaskbot update-policies

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Aug 26, 2024

Policies updated

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Aug 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Aug 27, 2024

Builds ready [91f63ce]
Page Load Metrics (75 ± 8 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint711791032512
domContentLoaded4410770189
load5110775178
domInteractive95726136
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -156.71 KiB (-4.34%)
  • ui: 0 Bytes (0.00%)
  • common: -273.85 KiB (-3.23%)

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.09%. Comparing base (ee52d48) to head (91f63ce).
Report is 15 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #26655      +/-   ##
===========================================
- Coverage    70.09%   70.09%   -0.00%     
===========================================
  Files         1413     1413              
  Lines        49254    49255       +1     
  Branches     13768    13768              
===========================================
  Hits         34524    34524              
- Misses       14730    14731       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritave ritave marked this pull request as ready for review August 27, 2024 13:36
@ritave ritave requested review from a team as code owners August 27, 2024 13:36
@ritave ritave merged commit aea494d into develop Aug 27, 2024
@ritave ritave deleted the ritave/approval-type branch August 27, 2024 14:11
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 27, 2024
@metamaskbot metamaskbot added the release-12.5.0 Issue or pull request that will be included in release 12.5.0 label Aug 27, 2024
@gauthierpetetin gauthierpetetin added release-12.4.0 Issue or pull request that will be included in release 12.4.0 and removed release-12.5.0 Issue or pull request that will be included in release 12.5.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jpuri jpuri jpuri approved these changes

@Mrtenz Mrtenz Mrtenz approved these changes

Assignees

No one assigned

Labels

release-12.4.0 Issue or pull request that will be included in release 12.4.0 team-confirmations Push issues to confirmations team team-snaps-platform-deprecated DEPRECATED: please use "team-core-platform" instead (or "team-new-networks" for Solana snap issues)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add the new default snap dialog approval type to ApprovalType

5 participants

@ritave @metamaskbot @jpuri @Mrtenz @gauthierpetetin