feat: Adding context to get current confirmation PR-4#26649
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
Builds ready [d7f6945]
Page Load Metrics (90 ± 12 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #26649 +/- ##
===========================================
+ Coverage 70.12% 70.13% +0.01%
===========================================
Files 1423 1424 +1
Lines 49539 49568 +29
Branches 13864 13868 +4
===========================================
+ Hits 34736 34763 +27
- Misses 14803 14805 +2 ☔ View full report in Codecov by Sentry. |
matthewwalsh0
previously approved these changes
Aug 29, 2024
digiwand
suggested changes
Aug 31, 2024
Contributor
digiwand
left a comment
There was a problem hiding this comment.
Nice work! minor TS suggesiton to remove as unknown
ui/pages/confirmations/hooks/useCurrentSignatureSecurityAlertResponse.test.ts
Outdated
Show resolved
Hide resolved
digiwand
reviewed
Aug 31, 2024
Collaborator
Builds ready [0c90ccb]
Page Load Metrics (1745 ± 139 ms)
Bundle size diffs
|
Collaborator
Builds ready [dbf1d1c]
Page Load Metrics (1485 ± 47 ms)
Bundle size diffs
|
|
Collaborator
Builds ready [710b825]
Page Load Metrics (1778 ± 50 ms)
Bundle size diffs
|
matthewwalsh0
approved these changes
Sep 3, 2024
| }; | ||
|
|
||
| if (!currentConfirmation?.msgParams) { | ||
| if (!(currentConfirmation as SignatureRequestType)?.msgParams) { |
Contributor
There was a problem hiding this comment.
Nit: This type may not be needed given it's already used above
Contributor
Author
There was a problem hiding this comment.
good point this is indeed not needed, I will fix this in following PR
pedronfigueiredo
approved these changes
Sep 3, 2024
digiwand
approved these changes
Sep 3, 2024
hmalik88
approved these changes
Sep 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Using context to get currently selected confirmation in re-designed confirmation pages. This is done to switch to using react context transient UI state in re-designed confirmation pages.
Related issues
Ref: #26414
Manual testing steps
NA
Screenshots/Recordings
NA
Pre-merge author checklist
Pre-merge reviewer checklist