feat: Adding context to get current confirmation PR-3#26645
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
b8fb226 to
119e446
Compare
119e446 to
c6280c2
Compare
Collaborator
Builds ready [59d707a]
Page Load Metrics (83 ± 9 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #26645 +/- ##
===========================================
- Coverage 70.12% 70.11% -0.01%
===========================================
Files 1421 1422 +1
Lines 49524 49526 +2
Branches 13863 13863
===========================================
- Hits 34728 34725 -3
- Misses 14796 14801 +5 ☔ View full report in Codecov by Sentry. |
matthewwalsh0
previously approved these changes
Aug 29, 2024
| const currentConfirmation = useSelector(currentConfirmationSelector) as | ||
| | TransactionMeta | ||
| | undefined; | ||
| const { currentConfirmation } = useConfirmContext() as unknown as { |
Member
There was a problem hiding this comment.
Minor, is it worth using a template on useConfirmContext to avoid the casting in future?
Something like:
const { currentConfirmation } = useConfirmContext<TransactionMeta>();
digiwand
previously approved these changes
Aug 31, 2024
jpuri
commented
Sep 2, 2024
Collaborator
Builds ready [9d87c7b]
Page Load Metrics (1884 ± 67 ms)
Bundle size diffs
|
|
Collaborator
Builds ready [17a2c63]
Page Load Metrics (1664 ± 61 ms)
Bundle size diffs
|
pedronfigueiredo
approved these changes
Sep 2, 2024
digiwand
approved these changes
Sep 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Using context to get currently selected confirmation in re-designed confirmation pages. This is done to switch to using react context transient UI state in re-designed confirmation pages.
Related issues
Ref: #26414
Manual testing steps
NA
Screenshots/Recordings
NA
Pre-merge author checklist
Pre-merge reviewer checklist