Skip to content

chore: bump smart transactions controller#26644

Merged
bergeron merged 2 commits intodevelopfrom
brian/bump-smart-tx-controller
Aug 26, 2024
Merged

chore: bump smart transactions controller#26644
bergeron merged 2 commits intodevelopfrom
brian/bump-smart-tx-controller

Conversation

@bergeron
Copy link
Copy Markdown
Contributor

@bergeron bergeron commented Aug 23, 2024 •
edited by github-actions bot
Loading

Description

Bumps smart transaction controller, so a patch is no longer needed

Open in GitHub Codespaces

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@bergeron bergeron requested a review from a team as a code owner August 23, 2024 20:02
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 23, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security
Copy link
Copy Markdown

socket-security bot commented Aug 23, 2024 •
edited
Loading

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/smart-transactions-controller@12.0.1 network 0 184 kB metamaskbot

View full report↗︎

@socket-security
Copy link
Copy Markdown

socket-security bot commented Aug 23, 2024 •
edited
Loading

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Network access npm/@metamask/smart-transactions-controller@12.0.1 🚫

View full report↗︎

Next steps

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/@metamask/smart-transactions-controller@12.0.1

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Aug 23, 2024

Builds ready [f235818]
Page Load Metrics (79 ± 17 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint673061074823
domContentLoaded41218743718
load48218793517
domInteractive1010628209
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -427 Bytes (-0.01%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.10%. Comparing base (800a9d3) to head (f235818).

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #26644      +/-   ##
===========================================
- Coverage    70.10%   70.10%   -0.00%     
===========================================
  Files         1413     1413              
  Lines        49257    49257              
  Branches     13769    13769              
===========================================
- Hits         34529    34528       -1     
- Misses       14728    14729       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bergeron bergeron mentioned this pull request Aug 23, 2024
Merged
7 tasks
@bergeron bergeron requested a review from legobeat August 23, 2024 20:51
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Aug 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@bergeron
Copy link
Copy Markdown
Contributor Author

bergeron commented Aug 26, 2024

unrelated phishing controller test failing, might need this merged:

MetaMask/eth-phishing-detect#78710

@bergeron bergeron merged commit 23aabcd into develop Aug 26, 2024
@bergeron bergeron deleted the brian/bump-smart-tx-controller branch August 26, 2024 04:36
@github-actions github-actions bot locked and limited conversation to collaborators Aug 26, 2024
@metamaskbot metamaskbot added the release-12.5.0 Issue or pull request that will be included in release 12.5.0 label Aug 26, 2024
@gauthierpetetin gauthierpetetin added release-12.4.0 Issue or pull request that will be included in release 12.4.0 and removed release-12.5.0 Issue or pull request that will be included in release 12.5.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@gambinish gambinish gambinish approved these changes

+1 more reviewer

@legobeat legobeat legobeat approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-12.4.0 Issue or pull request that will be included in release 12.4.0 team-assets

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bergeron @metamaskbot @gambinish @legobeat @gauthierpetetin