perf: add trace for UI startup by matthewwalsh0 · Pull Request #26636 · MetaMask/metamask-extension

matthewwalsh0 · 2024-08-23T12:32:24Z

Description

Record a UI Startup Sentry trace to monitor startup times of the UI pages.

In addition:

Support use of trace utility function in non-asynchronous contexts.
- Remove getMetaMetricsEnabled check as this is already done in the custom transport before submission.
Generate default ID if omitted when starting and ending traces.

Related issues

Fixes: #25724

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Support synchronous trace.

metamaskbot · 2024-08-23T17:19:34Z

Builds ready [21e6184]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (83 ± 18 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	70	245	106	40	19
		domContentLoaded	44	215	79	40	19
		load	52	215	83	38	18
		domInteractive	10	151	36	32	15

Bundle size diffs [🚀 Bundle size reduced!]

background: 0 Bytes (0.00%)
ui: 1006 Bytes (0.01%)
common: -56 Bytes (-0.00%)

codecov · 2024-08-23T17:20:04Z

Codecov Report

Attention: Patch coverage is 54.02299% with 40 lines in your changes missing coverage. Please review.

Project coverage is 70.07%. Comparing base (d9e989e) to head (b543539).
Report is 3 commits behind head on develop.

Files	Patch %	Lines
ui/index.js	0.00%	23 Missing ⚠️
app/scripts/ui.js	0.00%	10 Missing ⚠️
shared/lib/trace.ts	86.96%	6 Missing ⚠️
...nfirm-transaction/confirm-transaction.component.js	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #26636      +/-   ##
===========================================
- Coverage    70.09%   70.07%   -0.02%     
===========================================
  Files         1413     1413              
  Lines        49255    49288      +33     
  Branches     13768    13770       +2     
===========================================
+ Hits         34524    34536      +12     
- Misses       14731    14752      +21

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

app/scripts/ui.js

shared/lib/trace.ts

app/scripts/ui.js

ui/index.js

metamaskbot · 2024-08-27T14:47:50Z

Builds ready [0eec161]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (100 ± 8 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	101	177	132	19	9
		domContentLoaded	62	139	98	19	9
		load	71	140	100	18	8
		domInteractive	19	59	40	11	5

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 49 Bytes (0.00%)
ui: 1.17 KiB (0.02%)
common: 346 Bytes (0.00%)

sonarqubecloud · 2024-08-27T16:19:07Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-08-27T21:34:30Z

Builds ready [b543539]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (89 ± 21 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	70	264	119	44	21
		domContentLoaded	49	247	84	46	22
		load	55	247	89	44	21
		domInteractive	10	59	30	14	7

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 49 Bytes (0.00%)
ui: 1.23 KiB (0.02%)
common: 437 Bytes (0.01%)

metamaskbot · 2024-09-06T17:09:50Z

Missing release label release-12.2.0 on PR. Adding release label release-12.2.0 on PR and removing other release labels(release-12.5.0), as PR was cherry-picked in branch 12.2.0.

Add UI startup trace

d6d2c27

Support synchronous trace.

matthewwalsh0 added the team-tiger-deprecated DEPRECATED: team no longer exists label Aug 23, 2024

github-actions bot added the team-confirmations Push issues to confirmations team label Aug 23, 2024

Support default trace ID

21e6184

matthewwalsh0 marked this pull request as ready for review August 23, 2024 16:41

matthewwalsh0 requested a review from a team as a code owner August 23, 2024 16:41

matthewwalsh0 commented Aug 23, 2024

View reviewed changes

app/scripts/ui.js Outdated Show resolved Hide resolved

davidmurdoch requested changes Aug 23, 2024

View reviewed changes

shared/lib/trace.ts Show resolved Hide resolved

app/scripts/ui.js Outdated Show resolved Hide resolved

app/scripts/ui.js Outdated Show resolved Hide resolved

ui/index.js Outdated Show resolved Hide resolved

Use enum for trace name

4fedf08

matthewwalsh0 requested a review from a team as a code owner August 27, 2024 12:35

matthewwalsh0 added 2 commits August 27, 2024 14:03

Merge branch 'develop' into chore/trace-ui-init

bfc5cd0

Fix linting

0eec161

Add missing trace names

b543539

davidmurdoch approved these changes Aug 27, 2024

View reviewed changes

pedronfigueiredo approved these changes Aug 28, 2024

View reviewed changes

matthewwalsh0 merged commit 84f4557 into develop Aug 28, 2024

matthewwalsh0 deleted the chore/trace-ui-init branch August 28, 2024 09:51

github-actions bot locked and limited conversation to collaborators Aug 28, 2024

metamaskbot added the release-12.5.0 Issue or pull request that will be included in release 12.5.0 label Aug 28, 2024

gauthierpetetin assigned matthewwalsh0 Aug 28, 2024

metamaskbot added release-12.2.0 Issue or pull request that will be included in release 12.2.0 and removed release-12.5.0 Issue or pull request that will be included in release 12.5.0 labels Sep 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

perf: add trace for UI startup#26636

perf: add trace for UI startup#26636
matthewwalsh0 merged 6 commits intodevelopfrom
chore/trace-ui-init

matthewwalsh0 commented Aug 23, 2024 •

edited

Loading

Uh oh!

metamaskbot commented Aug 23, 2024

Uh oh!

codecov bot commented Aug 23, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

metamaskbot commented Aug 27, 2024

Uh oh!

sonarqubecloud bot commented Aug 27, 2024

Uh oh!

metamaskbot commented Aug 27, 2024

Uh oh!

metamaskbot commented Sep 6, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

matthewwalsh0 commented Aug 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

metamaskbot commented Aug 23, 2024

Uh oh!

codecov bot commented Aug 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

metamaskbot commented Aug 27, 2024

Uh oh!

sonarqubecloud bot commented Aug 27, 2024

Quality Gate passed

Uh oh!

metamaskbot commented Aug 27, 2024

Uh oh!

metamaskbot commented Sep 6, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

matthewwalsh0 commented Aug 23, 2024 •

edited

Loading

codecov bot commented Aug 23, 2024 •

edited

Loading