Skip to content

Version v12.1.0-beta.0#26631

Merged
benjisclowder merged 1 commit intoVersion-v12.1.0from
release/v12.1.0-beta.0
Aug 23, 2024
Merged

Version v12.1.0-beta.0#26631
benjisclowder merged 1 commit intoVersion-v12.1.0from
release/v12.1.0-beta.0

Conversation

@Gudahtt
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt commented Aug 22, 2024 •
edited
Loading

Description

This PR will trigger the creation of a beta build once merged.

Open in GitHub Codespaces

Related issues

N/A

Manual testing steps

N/A

Screenshots/Recordings

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Gudahtt Gudahtt marked this pull request as ready for review August 22, 2024 23:01
@Gudahtt Gudahtt requested a review from a team as a code owner August 22, 2024 23:01
@Gudahtt Gudahtt force-pushed the release/v12.1.0-beta.0 branch from cbb95ec to 05f37bc Compare August 22, 2024 23:02
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.80%. Comparing base (5bdc48e) to head (05f37bc).
Report is 1 commits behind head on Version-v12.1.0.

Additional details and impacted files 
@@               Coverage Diff                @@
##           Version-v12.1.0   #26631   +/-   ##
================================================
  Coverage            69.80%   69.80%           
================================================
  Files                 1370     1370           
  Lines                48739    48739           
  Branches             13438    13438           
================================================
  Hits                 34019    34019           
  Misses               14720    14720

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Aug 23, 2024

Builds ready [05f37bc]
Page Load Metrics (256 ± 267 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint70130100189
domContentLoaded105421115
load432061256556267
domInteractive105421115

benjisclowder
benjisclowder approved these changes Aug 23, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@benjisclowder benjisclowder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benjisclowder benjisclowder merged commit e5f4f32 into Version-v12.1.0 Aug 23, 2024
@benjisclowder benjisclowder deleted the release/v12.1.0-beta.0 branch August 23, 2024 12:50
@github-actions github-actions bot locked and limited conversation to collaborators Aug 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@benjisclowder benjisclowder benjisclowder approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Gudahtt @metamaskbot @benjisclowder