chore: anonymize send analytic properties#26627
Merged
Gudahtt merged 3 commits intoVersion-v12.1.0-swap-send-user-idfrom Aug 22, 2024
Merged
chore: anonymize send analytic properties#26627Gudahtt merged 3 commits intoVersion-v12.1.0-swap-send-user-idfrom
Gudahtt merged 3 commits intoVersion-v12.1.0-swap-send-user-idfrom
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
micaelae
approved these changes
Aug 22, 2024
Gudahtt
reviewed
Aug 22, 2024
Gudahtt
reviewed
Aug 22, 2024
ui/components/multichain/asset-picker-amount/asset-picker-modal/asset-picker-modal.tsx
Outdated
Show resolved
Hide resolved
Gudahtt
approved these changes
Aug 22, 2024
Member
Gudahtt
left a comment
There was a problem hiding this comment.
LGTM! Could you also submit this to develop at the earliest opportunity? So we don't accidentally undo this when we sync this release into develop later.
7 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## Version-v12.1.0-swap-send-user-id #26627 +/- ##
==================================================================
Coverage 69.83% 69.83%
==================================================================
Files 1368 1368
Lines 48655 48655
Branches 13435 13435
==================================================================
Hits 33974 33974
Misses 14681 14681 ☔ View full report in Codecov by Sentry. |
Collaborator
Builds ready [9ec185b]
Page Load Metrics (145 ± 148 ms)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Certain send analytics can be used to correlated metric IDs with analytics data; this PR marks these as sensitive.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist