feat: Adding context to get current confirmation PR-2#26619
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
0937983 to
52c9891
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #26619 +/- ##
===========================================
+ Coverage 70.08% 70.09% +0.01%
===========================================
Files 1414 1415 +1
Lines 49327 49328 +1
Branches 13781 13779 -2
===========================================
+ Hits 34567 34572 +5
+ Misses 14760 14756 -4 ☔ View full report in Codecov by Sentry. |
Collaborator
Builds ready [c6b35fb]
Page Load Metrics (87 ± 9 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
digiwand
suggested changes
Aug 23, 2024
Contributor
digiwand
left a comment
There was a problem hiding this comment.
The transition to context is looking great! Had a couple of comments above related to tests and a condition
| }, | ||
| }, | ||
| }; | ||
| const mockStore = getExampleMockSignatureConfirmState(); |
Contributor
There was a problem hiding this comment.
[suggestion] I think "ExampleMock" could be redundant. I would recommend getMockSignatureConfirmState. Similar comment for the other helper mocks
Contributor
Author
There was a problem hiding this comment.
This name I have changed already in following PRs.
ui/pages/confirmations/hooks/useCurrentSignatureSecurityAlertResponse.ts
Show resolved
Hide resolved
Collaborator
Builds ready [7b24f9f]
Page Load Metrics (73 ± 9 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
matthewwalsh0
previously approved these changes
Aug 27, 2024
| time: new Date().getTime(), | ||
| type: 'personal_sign', | ||
| securityProviderResponse: null, | ||
| chainid: '0x5', |
Member
There was a problem hiding this comment.
Should this also use mockState.metamask.networkConfigurations.goerli.chainId?
Contributor
Author
There was a problem hiding this comment.
The object not not using mockState.metamask otherwise thus I would avoid importing it for just chainId.
|
Collaborator
Builds ready [6c4b939]
Page Load Metrics (1839 ± 86 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
digiwand
approved these changes
Aug 31, 2024
matthewwalsh0
approved these changes
Sep 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Using context to get currently selected confirmation in re-designed confirmation pages. This is done to switch to using react context transient UI state in re-designed confirmation pages.
Related issues
Ref: #26414
Manual testing steps
NA
Screenshots/Recordings
NA
Pre-merge author checklist
Pre-merge reviewer checklist