Skip to content

chore: add user IDs to send page analytics#26600

Merged
BZahory merged 2 commits intodevelopfrom
send-page-analytics
Aug 22, 2024
Merged

chore: add user IDs to send page analytics#26600
BZahory merged 2 commits intodevelopfrom
send-page-analytics

Conversation

@BZahory
Copy link
Copy Markdown
Contributor

@BZahory BZahory commented Aug 22, 2024 •
edited by github-actions bot
Loading

Description

We currently anonymize all send page events. This PR introduces logic that allows for explicitly overriding this logic for vetted send page events, so that we can create funnels to track user dropoff.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Log the payload in _track()
  2. Complete a swap+send transaction, starting from the home page
  3. Ensure send flow events are fired w/ user IDs

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@BZahory BZahory requested a review from a team as a code owner August 22, 2024 01:45
@BZahory BZahory changed the title Send page analytics chore: add user IDs to send page analytics Aug 22, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 22, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-bridge-deprecated DEPRECATED: please use "team-swaps-and-bridge" instead label Aug 22, 2024
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Aug 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 30.76923% with 9 lines in your changes missing coverage. Please review.

Project coverage is 70.01%. Comparing base (187da88) to head (12888af).

Files Patch % Lines
...omponents/app/assets/nfts/nfts-items/nfts-items.js 0.00% 1 Missing ⚠️
ui/components/app/wallet-overview/coin-buttons.tsx 0.00% 1 Missing ⚠️
...r-amount/asset-picker-modal/asset-picker-modal.tsx 0.00% 1 Missing ⚠️
.../asset-picker-amount/asset-picker/asset-picker.tsx 0.00% 1 Missing ⚠️
.../multichain/pages/send/components/address-book.tsx 0.00% 1 Missing ⚠️
...ltichain/pages/send/components/recipient-input.tsx 0.00% 1 Missing ⚠️
...nts/multichain/pages/send/components/recipient.tsx 0.00% 1 Missing ⚠️
ui/components/multichain/pages/send/send.js 50.00% 1 Missing ⚠️
ui/pages/asset/components/token-buttons.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #26600   +/-   ##
========================================
  Coverage    70.01%   70.01%           
========================================
  Files         1410     1410           
  Lines        49130    49130           
  Branches     13739    13739           
========================================
  Hits         34398    34398           
  Misses       14732    14732

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Aug 22, 2024

Builds ready [12888af]
Page Load Metrics (70 ± 6 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint7215194189
domContentLoaded5410668126
load5710670126
domInteractive20412653
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 55 Bytes (0.00%)
  • ui: 312 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@BZahory BZahory merged commit 6088797 into develop Aug 22, 2024
@BZahory BZahory deleted the send-page-analytics branch August 22, 2024 18:02
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2024
@metamaskbot metamaskbot added the release-12.5.0 Issue or pull request that will be included in release 12.5.0 label Aug 22, 2024
@gauthierpetetin gauthierpetetin added release-12.4.0 Issue or pull request that will be included in release 12.4.0 and removed release-12.5.0 Issue or pull request that will be included in release 12.5.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ejwessel ejwessel ejwessel approved these changes

@micaelae micaelae micaelae approved these changes

Assignees

No one assigned

Labels

release-12.4.0 Issue or pull request that will be included in release 12.4.0 team-bridge-deprecated DEPRECATED: please use "team-swaps-and-bridge" instead

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@BZahory @metamaskbot @ejwessel @micaelae @gauthierpetetin