fix: bump accounts controller and migration to fix undefined selectedAccount by montelaidev · Pull Request #26573 · MetaMask/metamask-extension

montelaidev · 2024-08-21T12:52:19Z

Description

This PR bumps the AccountsController and introduces a new migration. The updateAccounts methods from the AccountsController now checks if the selectedAccount is undefined and recovers from this. The migration updates the selectedAccount values that are not defined.

Related issues

Fixes: #26377

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-08-21T12:52:31Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

…ctedAccount

socket-security · 2024-08-21T12:57:23Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/accounts-controller@18.1.0	None	`0`	391 kB	metamaskbot
npm/@metamask/keyring-api@8.1.0	None	`0`	250 kB	metamaskbot

🚮 Removed packages: npm/@metamask/accounts-controller@17.2.0), npm/@metamask/keyring-api@8.0.0)

View full report↗︎

montelaidev · 2024-08-21T14:25:32Z

@metamaskbot update-policies

metamaskbot · 2024-08-21T14:37:25Z

Policies updated

codecov · 2024-08-21T16:59:04Z

Codecov Report

Attention: Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.05%. Comparing base (590f0a9) to head (e6a2d32).
Report is 19 commits behind head on develop.

Files	Patch %	Lines
...nents/multichain/pages/connections/connections.tsx	88.89%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #26573      +/-   ##
===========================================
+ Coverage    70.02%   70.05%   +0.02%     
===========================================
  Files         1406     1411       +5     
  Lines        49076    49219     +143     
  Branches     13725    13757      +32     
===========================================
+ Hits         34364    34476     +112     
- Misses       14712    14743      +31

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2024-08-21T17:12:00Z

Builds ready [7d5955c]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (76 ± 7 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	74	124	101	14	7
		domContentLoaded	50	95	72	13	6
		load	50	102	76	14	7
		domInteractive	9	53	28	9	4

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 48.78 KiB (1.37%)
ui: -5 Bytes (-0.00%)
common: 26.6 KiB (0.32%)

gantunesr

Looks like, left some minor comments

ui/components/multichain/pages/connections/connections.tsx

ui/pages/remove-snap-account/snap-account-card.tsx

ui/selectors/selectors.types.ts

sonarqubecloud · 2024-08-22T11:58:02Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-08-22T12:34:49Z

Builds ready [e6a2d32]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (82 ± 18 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	65	289	118	52	25
		domContentLoaded	39	201	79	39	19
		load	46	201	82	38	18
		domInteractive	9	87	31	18	9

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 48.78 KiB (1.37%)
ui: -5 Bytes (-0.00%)
common: 26.6 KiB (0.32%)

k-g-j · 2024-08-22T15:10:17Z

ui/pages/remove-snap-account/snap-account-card.tsx

@@ -24,7 +25,7 @@ export const SnapAccountCard = ({
  const account = mergedAccounts.find(


Adding a note here as a TODO for us to remove the need of mergeAccounts

fix: bump accounts controller and add migration to fix undefined sele…

0e1cb3e

…ctedAccount

montelaidev force-pushed the fix/26377 branch from 673c8e7 to 0e1cb3e Compare August 21, 2024 12:56

montelaidev added 3 commits August 21, 2024 21:52

chore: update policies

5b21f1c

fix: lint

77d2e55

chore: dedupe

1ee9e03

Update LavaMoat policies

9183c22

montelaidev self-assigned this Aug 21, 2024

montelaidev added the team-accounts-framework Accounts team label Aug 21, 2024

fix: lint

7d5955c

montelaidev marked this pull request as ready for review August 21, 2024 16:31

montelaidev requested review from a team as code owners August 21, 2024 16:31

montelaidev changed the title ~~fix: 26377~~ fix: bump accounts controller and migration to fix undefined selectedAccount Aug 21, 2024

gantunesr reviewed Aug 22, 2024

View reviewed changes

ui/components/multichain/pages/connections/connections.tsx Outdated Show resolved Hide resolved

ui/pages/remove-snap-account/snap-account-card.tsx Show resolved Hide resolved

ui/selectors/selectors.types.ts Outdated Show resolved Hide resolved

fix: remove unneeded type and rename variables

e6a2d32

gantunesr approved these changes Aug 22, 2024

View reviewed changes

k-g-j reviewed Aug 22, 2024

View reviewed changes

k-g-j approved these changes Aug 22, 2024

View reviewed changes

montelaidev merged commit 759b92e into develop Aug 22, 2024

montelaidev deleted the fix/26377 branch August 22, 2024 15:42

github-actions bot locked and limited conversation to collaborators Aug 22, 2024

metamaskbot added the release-12.5.0 Issue or pull request that will be included in release 12.5.0 label Aug 22, 2024

gauthierpetetin added release-12.4.0 Issue or pull request that will be included in release 12.4.0 and removed release-12.5.0 Issue or pull request that will be included in release 12.5.0 labels Sep 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: bump accounts controller and migration to fix undefined selectedAccount#26573

fix: bump accounts controller and migration to fix undefined selectedAccount#26573
montelaidev merged 7 commits intodevelopfrom
fix/26377

montelaidev commented Aug 21, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Aug 21, 2024

Uh oh!

socket-security bot commented Aug 21, 2024 •

edited

Loading

Uh oh!

montelaidev commented Aug 21, 2024

Uh oh!

metamaskbot commented Aug 21, 2024

Uh oh!

codecov bot commented Aug 21, 2024 •

edited

Loading

Uh oh!

metamaskbot commented Aug 21, 2024

Uh oh!

gantunesr left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Aug 22, 2024

Uh oh!

metamaskbot commented Aug 22, 2024

Uh oh!

k-g-j Aug 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

		@@ -24,7 +25,7 @@ export const SnapAccountCard = ({
		const account = mergedAccounts.find(

Conversation

montelaidev commented Aug 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Aug 21, 2024

Uh oh!

socket-security bot commented Aug 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

montelaidev commented Aug 21, 2024

Uh oh!

metamaskbot commented Aug 21, 2024

Uh oh!

codecov bot commented Aug 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

metamaskbot commented Aug 21, 2024

Uh oh!

gantunesr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Aug 22, 2024

Quality Gate passed

Uh oh!

metamaskbot commented Aug 22, 2024

Uh oh!

k-g-j Aug 22, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

montelaidev commented Aug 21, 2024 •

edited

Loading

socket-security bot commented Aug 21, 2024 •

edited

Loading

codecov bot commented Aug 21, 2024 •

edited

Loading