fix: NetworkChangeToast width in wide screen mode#26532
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
matthewwalsh0
previously approved these changes
Aug 20, 2024
|
|
||
| @media screen and (min-width: 576px) { | ||
| .toast_wrapper { | ||
| max-width: 408px; |
Member
There was a problem hiding this comment.
Minor, but do we have SCSS variables for either of these numbers?
Contributor
Author
There was a problem hiding this comment.
I could not find for with, but there was one for breakpoint which I added.
pedronfigueiredo
previously approved these changes
Aug 20, 2024
matthewwalsh0
previously approved these changes
Aug 20, 2024
|
pedronfigueiredo
approved these changes
Aug 20, 2024
matthewwalsh0
approved these changes
Aug 20, 2024
Collaborator
Builds ready [1a2a4fe]
Page Load Metrics (71 ± 8 ms)
Bundle size diffs
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #26532 +/- ##
========================================
Coverage 69.96% 69.96%
========================================
Files 1405 1405
Lines 48996 48996
Branches 13697 13697
========================================
Hits 34280 34280
Misses 14716 14716 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Network change toast looks broken in wide screen
Related issues
Fixes: #26527
Manual testing steps
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist