Skip to content

fix: Sentry app state null data to show null as value.#26522

Merged
hjetpoluru merged 2 commits intodevelopfrom
sentry-state-null-data
Aug 29, 2024
Merged

fix: Sentry app state null data to show null as value.#26522
hjetpoluru merged 2 commits intodevelopfrom
sentry-state-null-data

Conversation

@NiranjanaBinoy
Copy link
Copy Markdown
Contributor

@NiranjanaBinoy NiranjanaBinoy commented Aug 19, 2024 •
edited by github-actions bot
Loading

Description

Updating the sentry app state to show a null value when the data is null when the property is not masked.

Open in GitHub Codespaces

Related issues

Fixes:
#25959

Manual testing steps

Run this.stateHooks.getSentryAppState() in the console and check if the unmasked null values are stored as null.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@NiranjanaBinoy NiranjanaBinoy added the team-extension-platform Extension Platform team label Aug 19, 2024
@NiranjanaBinoy NiranjanaBinoy self-assigned this Aug 19, 2024
@NiranjanaBinoy NiranjanaBinoy requested a review from a team as a code owner August 19, 2024 18:55
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 19, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.09%. Comparing base (81af2e8) to head (39ade73).
Report is 61 commits behind head on develop.

Files Patch % Lines
shared/modules/object.utils.js 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #26522      +/-   ##
===========================================
+ Coverage    69.96%   70.09%   +0.13%     
===========================================
  Files         1405     1413       +8     
  Lines        48996    49283     +287     
  Branches     13697    13786      +89     
===========================================
+ Hits         34280    34544     +264     
- Misses       14716    14739      +23

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Aug 19, 2024

Builds ready [5b0d4c2]
Page Load Metrics (89 ± 14 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint751941152814
domContentLoaded44167852814
load51168892814
domInteractive107532178
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 17 Bytes (0.00%)

@NiranjanaBinoy NiranjanaBinoy changed the title Sentry app state null data to show null as value. fix: Sentry app state null data to show null as value. Aug 20, 2024
itsyoboieltr
itsyoboieltr previously approved these changes Aug 22, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@itsyoboieltr itsyoboieltr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Aug 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Aug 28, 2024

Builds ready [39ade73]
Page Load Metrics (79 ± 9 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint71131105189
domContentLoaded4211075199
load5011279189
domInteractive105527115
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 17 Bytes (0.00%)

@hjetpoluru hjetpoluru self-requested a review August 29, 2024 16:16
@hjetpoluru hjetpoluru merged commit e8273d8 into develop Aug 29, 2024
@hjetpoluru hjetpoluru deleted the sentry-state-null-data branch August 29, 2024 16:17
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2024
@metamaskbot metamaskbot added the release-12.5.0 Issue or pull request that will be included in release 12.5.0 label Aug 29, 2024
@gauthierpetetin gauthierpetetin added release-12.4.0 Issue or pull request that will be included in release 12.4.0 and removed release-12.5.0 Issue or pull request that will be included in release 12.5.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@itsyoboieltr itsyoboieltr itsyoboieltr approved these changes

@hjetpoluru hjetpoluru hjetpoluru approved these changes

Assignees

@NiranjanaBinoy NiranjanaBinoy

Labels

release-12.4.0 Issue or pull request that will be included in release 12.4.0 team-extension-platform Extension Platform team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@NiranjanaBinoy @metamaskbot @itsyoboieltr @hjetpoluru @gauthierpetetin