Skip to content

cherry-pick: Add signature insights hotfix to RC#26506

Merged
Gudahtt merged 1 commit intoVersion-v12.0.6from
fb/cherry-pick-rc-insights-hotfix
Aug 19, 2024
Merged

cherry-pick: Add signature insights hotfix to RC#26506
Gudahtt merged 1 commit intoVersion-v12.0.6from
fb/cherry-pick-rc-insights-hotfix

Conversation

@FrederikBolding
Copy link
Copy Markdown
Member

Description

Cherry-picks ee8009f to the 12.0.6 RC to fix a Sentry error triggered by msgParams being undefined.

…26248)

## **Description**

Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change? Sentry was showing `undefined`
parameters for a signature insight call, it was found that this was
reproducible when a signature request was rejected.
2. What is the improvement/solution? Added an extra condition to prevent
unnecessary calls to `fetchInsight` in the `useSignatureInsights` hook.

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@FrederikBolding FrederikBolding requested a review from a team as a code owner August 19, 2024 14:31
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@FrederikBolding FrederikBolding added the team-snaps-platform-deprecated DEPRECATED: please use "team-core-platform" instead (or "team-new-networks" for Solana snap issues) label Aug 19, 2024
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Aug 19, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.75%. Comparing base (203e5d7) to head (76042e5).
Report is 1 commits behind head on Version-v12.0.6.

Additional details and impacted files
@@               Coverage Diff                @@
##           Version-v12.0.6   #26506   +/-   ##
================================================
  Coverage            65.75%   65.75%           
================================================
  Files                 1372     1372           
  Lines                54766    54766           
  Branches             14260    14260           
================================================
  Hits                 36006    36006           
  Misses               18760    18760           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [76042e5]
Page Load Metrics (49 ± 4 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint69987974
domContentLoaded8171021
load41634974
domInteractive8171021

Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit 6188c5c into Version-v12.0.6 Aug 19, 2024
@Gudahtt Gudahtt deleted the fb/cherry-pick-rc-insights-hotfix branch August 19, 2024 16:19
@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template team-snaps-platform-deprecated DEPRECATED: please use "team-core-platform" instead (or "team-new-networks" for Solana snap issues)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants