Skip to content

perf: add parallel fetching for the network fee dropdown#26489

Merged
Prithpal-Sooriya merged 1 commit intodevelopfrom
network-fee-parallel-fetching
Aug 19, 2024
Merged

perf: add parallel fetching for the network fee dropdown#26489
Prithpal-Sooriya merged 1 commit intodevelopfrom
network-fee-parallel-fetching

Conversation

@Prithpal-Sooriya
Copy link
Copy Markdown
Contributor

@Prithpal-Sooriya Prithpal-Sooriya commented Aug 17, 2024 •
edited by github-actions bot
Loading

Description

This improve the network fee loading in the notification modal from ~3s to ~1s.

Open in GitHub Codespaces

Related issues

Fixes: N/A

Manual testing steps

Test opening a notification.

Screenshots/Recordings

Before

Screenshot 2024-08-17 at 18 19 40

After

Screenshot 2024-08-17 at 18 20 44

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Prithpal-Sooriya Prithpal-Sooriya added the team-notifications-deprecated DEPRECATED: please use "team-assets" instead label Aug 17, 2024
@Prithpal-Sooriya Prithpal-Sooriya requested a review from a team as a code owner August 17, 2024 18:22
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 17, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Aug 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.17%. Comparing base (f659700) to head (349bcc0).
Report is 2 commits behind head on develop.

Files Patch % Lines
ui/helpers/utils/notification.util.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #26489   +/-   ##
========================================
  Coverage    70.17%   70.17%           
========================================
  Files         1424     1424           
  Lines        49857    49856    -1     
  Branches     13852    13852           
========================================
+ Hits         34985    34986    +1     
+ Misses       14872    14870    -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Aug 17, 2024

Builds ready [349bcc0]
Page Load Metrics (69 ± 10 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint68202983014
domContentLoaded47143652211
load53143692110
domInteractive149429189
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 4 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Jonathansoufer
Jonathansoufer approved these changes Aug 17, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@Jonathansoufer Jonathansoufer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvement!

@Prithpal-Sooriya Prithpal-Sooriya merged commit 69696bb into develop Aug 19, 2024
@Prithpal-Sooriya Prithpal-Sooriya deleted the network-fee-parallel-fetching branch August 19, 2024 09:35
@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2024
@metamaskbot metamaskbot added the release-12.5.0 Issue or pull request that will be included in release 12.5.0 label Aug 19, 2024
@gauthierpetetin gauthierpetetin added release-12.4.0 Issue or pull request that will be included in release 12.4.0 and removed release-12.5.0 Issue or pull request that will be included in release 12.5.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mathieuartu mathieuartu mathieuartu approved these changes

+1 more reviewer

@Jonathansoufer Jonathansoufer Jonathansoufer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-12.4.0 Issue or pull request that will be included in release 12.4.0 team-notifications-deprecated DEPRECATED: please use "team-assets" instead

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Prithpal-Sooriya @metamaskbot @mathieuartu @Jonathansoufer @gauthierpetetin