docs: Include MV2 build commands in README#26486
Merged
HowardBraham merged 1 commit intodevelopfrom Aug 19, 2024
Merged
Conversation
The build instructions in the README are misleading at the moment because they make no reference to MV2. This could lead to contributors using MV3 builds with Firefox, leading to errors. They have been updated to recommend the MV2 build commands when working with Firefox.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #26486 +/- ##
========================================
Coverage 70.17% 70.17%
========================================
Files 1424 1424
Lines 49857 49857
Branches 13852 13852
========================================
Hits 34985 34985
Misses 14872 14872 ☔ View full report in Codecov by Sentry. |
Collaborator
Builds ready [39c1911]
Page Load Metrics (82 ± 10 ms)
Bundle size diffs
|
mikesposito
approved these changes
Aug 19, 2024
HowardBraham
approved these changes
Aug 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The build instructions in the README are misleading at the moment because they make no reference to MV2. This could lead to contributors using MV3 builds with Firefox, leading to errors.
They have been updated to recommend the MV2 build commands when working with Firefox.
Related issues
N/A
Manual testing steps
N/A
Screenshots/Recordings
N/A
Pre-merge author checklist
Pre-merge reviewer checklist