feat(notifications): use shared libraries NotificationServicesController by Prithpal-Sooriya · Pull Request #26480 · MetaMask/metamask-extension

Prithpal-Sooriya · 2024-08-16T17:21:19Z

Description

This removes our old MetaMaskNotificationsController and uses our shared NotificationServicesController. This controller is identical to the old one, but replacing it so we have shared controllers for Mobile and Extension.

Related issues

Fixes: N/A

Manual testing steps

Test Notifications flows

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

… notify_840-use-notification-services-push-controller

… controller

… notify_840-use-notification-services-controller

github-actions · 2024-08-16T17:21:34Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

sentry · 2024-08-16T17:21:37Z

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: app/scripts/background.js

Function	Unhandled Issue
`setupController`	TypeError: t.has is not a function _checkPrivateR... `Event Count:` 1 `Affected Users:` 0
`setupController`	SyntaxError: Invalid or unexpected token setupCon... `Event Count:` 1 `Affected Users:` 0
`setupController`	TypeError: Cannot read properties of undefined (reading 'getVersion') new MetamaskController(app/scripts/me... `Event Count:` 1 `Affected Users:` 0

_{Did you find this useful? React with a 👍 or 👎}

metamaskbot · 2024-08-16T18:53:09Z

Builds ready [a5a01e8]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (81 ± 19 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	69	282	109	44	21
		domContentLoaded	40	235	77	41	20
		load	47	235	81	40	19
		domInteractive	9	190	33	38	18

Bundle size diffs [🚀 Bundle size reduced!]

background: -576.76 KiB (-14.76%)
ui: -1.34 KiB (-0.02%)
common: 542.5 KiB (7.41%)

codecov · 2024-08-16T18:53:16Z

Codecov Report

Attention: Patch coverage is 75.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 69.98%. Comparing base (69696bb) to head (43de4b4).
Report is 1 commits behind head on develop.

Files	Patch %	Lines
app/scripts/background.js	0.00%	6 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #26480      +/-   ##
===========================================
- Coverage    70.19%   69.98%   -0.22%     
===========================================
  Files         1420     1405      -15     
  Lines        49767    48991     -776     
  Branches     13828    13697     -131     
===========================================
- Hits         34933    34282     -651     
+ Misses       14834    14709     -125

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

matteoscurati

LGTM

…roller

sonarqubecloud · 2024-08-19T09:38:48Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-08-19T10:50:39Z

Builds ready [43de4b4]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (80 ± 22 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	73	316	111	50	24
		domContentLoaded	42	277	78	48	23
		load	50	277	80	47	22
		domInteractive	11	171	31	33	16

Bundle size diffs [🚀 Bundle size reduced!]

background: -576.76 KiB (-14.76%)
ui: -1.34 KiB (-0.02%)
common: 542.5 KiB (7.41%)

Prithpal-Sooriya and others added 19 commits August 12, 2024 15:18

refactor: use core profile sync controller

bbfa164

refactor: use core AuthenticationController

b377dc4

refactor: use core UserStorageController

86cc3ba

Update LavaMoat policies

6c57755

refactor: dedupe lock file

968dd4f

refactor: update lavamoat policies

ee2b73e

Merge branch 'develop' into notify_840_use_profile_sync_controller

964ebd2

Merge branch 'develop' into notify_840_use_profile_sync_controller

5ad6097

refactor: replace and use shared push controller library

cfdaac8

Merge branch 'develop' of github.com:MetaMask/metamask-extension into…

79f2968

… notify_840-use-notification-services-push-controller

refactor: update policies

1ea602d

Merge branch 'develop' of github.com:MetaMask/metamask-extension into…

a2a3cc8

… notify_840-use-notification-services-push-controller

refactor: cleanup - reuse shared libraries for creating push message

5d63dd1

test: add back push notification message tests

309739e

refactor: update lockfile and policies

222f144

ci: fix locale linting for push notification translations

051a485

refactor: remove old controller, and use shared notification services…

47e4e59

… controller

refactor: remove unused packages and update policies

b52492c

Merge branch 'develop' of github.com:MetaMask/metamask-extension into…

71a46ba

… notify_840-use-notification-services-controller

Prithpal-Sooriya added the team-notifications-deprecated DEPRECATED: please use "team-assets" instead label Aug 16, 2024

Prithpal-Sooriya changed the title ~~refactor (notifications): use shared libraries NotificationServicesController~~ feat(notifications): use shared libraries NotificationServicesController Aug 16, 2024

Prithpal-Sooriya force-pushed the notify_840-use-notification-services-controller branch 2 times, most recently from 1db00e1 to a5a01e8 Compare August 16, 2024 18:18

test: update e2e sentry tests

a5a01e8

Prithpal-Sooriya marked this pull request as ready for review August 16, 2024 18:51

Prithpal-Sooriya requested review from a team as code owners August 16, 2024 18:51

Prithpal-Sooriya requested a review from a team as a code owner August 16, 2024 18:51

Prithpal-Sooriya requested review from mathieuartu and matteoscurati August 16, 2024 18:53

matteoscurati approved these changes Aug 19, 2024

View reviewed changes

mathieuartu approved these changes Aug 19, 2024

View reviewed changes

Merge branch 'develop' into notify_840-use-notification-services-cont…

43de4b4

…roller

Prithpal-Sooriya merged commit e3aef95 into develop Aug 19, 2024

Prithpal-Sooriya deleted the notify_840-use-notification-services-controller branch August 19, 2024 10:50

github-actions bot locked and limited conversation to collaborators Aug 19, 2024

metamaskbot added the release-12.5.0 Issue or pull request that will be included in release 12.5.0 label Aug 19, 2024

gauthierpetetin added release-12.4.0 Issue or pull request that will be included in release 12.4.0 and removed release-12.5.0 Issue or pull request that will be included in release 12.5.0 labels Sep 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(notifications): use shared libraries NotificationServicesController#26480

feat(notifications): use shared libraries NotificationServicesController#26480
Prithpal-Sooriya merged 21 commits intodevelopfrom
notify_840-use-notification-services-controller

Prithpal-Sooriya commented Aug 16, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Aug 16, 2024

Uh oh!

sentry bot commented Aug 16, 2024

Uh oh!

metamaskbot commented Aug 16, 2024

Uh oh!

codecov bot commented Aug 16, 2024 •

edited

Loading

Uh oh!

matteoscurati left a comment

Uh oh!

sonarqubecloud bot commented Aug 19, 2024

Uh oh!

metamaskbot commented Aug 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

Prithpal-Sooriya commented Aug 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Aug 16, 2024

Uh oh!

sentry bot commented Aug 16, 2024

🔍 Existing Issues For Review

Uh oh!

metamaskbot commented Aug 16, 2024

Uh oh!

codecov bot commented Aug 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

matteoscurati left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Aug 19, 2024

Quality Gate passed

Uh oh!

metamaskbot commented Aug 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Prithpal-Sooriya commented Aug 16, 2024 •

edited

Loading

codecov bot commented Aug 16, 2024 •

edited

Loading