fix: Snap Address component UI/UX (Snaps custom UI)#26477
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #26477 +/- ##
========================================
Coverage 69.96% 69.97%
========================================
Files 1405 1405
Lines 48996 48998 +2
Branches 13697 13699 +2
========================================
+ Hits 34280 34282 +2
Misses 14716 14716 ☔ View full report in Codecov by Sentry. |
Collaborator
Builds ready [23331d5]
Page Load Metrics (73 ± 10 ms)
Bundle size diffs
|
31bebad to
4492e21
Compare
4492e21 to
de76f97
Compare
|
Collaborator
Builds ready [de76f97]
Page Load Metrics (84 ± 9 ms)
Bundle size diffs
|
ritave
approved these changes
Aug 19, 2024
FrederikBolding
approved these changes
Aug 20, 2024
jpuri
approved these changes
Aug 20, 2024
Contributor
jpuri
left a comment
There was a problem hiding this comment.
Change look good, will be nicer to have unit test coverage also.
pedronfigueiredo
approved these changes
Aug 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Because of concerns around Snap custom UI address component not working as intended with Pet Names, decision was made to disable it's interactive UX and display shortened hexadecimal address instead of showing Pet name.
Changes on this PR will make Address component to ignore clicks and triggering the modal for nicknames.
Changes are applied only to Snaps related flows where Snaps components (custom UI) are used.
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2965
Manual testing steps
Screenshots/Recordings
Before
After
Customized Interactive UI Snap for the test case, just for reference:
Pre-merge author checklist
Pre-merge reviewer checklist