Skip to content

Fix merge conflict resolution error in request-queuing/ui.spec.js, for v12.1.0#26476

Merged
Gudahtt merged 3 commits intoVersion-v12.1.0from
fix-request-queue-e2e-tests
Aug 22, 2024
Merged

Fix merge conflict resolution error in request-queuing/ui.spec.js, for v12.1.0#26476
Gudahtt merged 3 commits intoVersion-v12.1.0from
fix-request-queue-e2e-tests

Conversation

@danjm
Copy link
Copy Markdown
Contributor

@danjm danjm commented Aug 16, 2024

This brings the tests up to date with develop, which is what they should have been. One test that was cherry-picked into v12.0.0 and then later updated on develop was not merge properly when master was merged into v12.1.0

@danjm danjm requested a review from a team as a code owner August 16, 2024 15:01
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added INVALID-PR-TEMPLATE PR's body doesn't match template team-extension-platform Extension Platform team labels Aug 16, 2024
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit 5bdc48e into Version-v12.1.0 Aug 22, 2024
@Gudahtt Gudahtt deleted the fix-request-queue-e2e-tests branch August 22, 2024 23:01
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [dd2194f]
Page Load Metrics (245 ± 254 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint654161167134
domContentLoaded10110342311
load432052245528254
domInteractive10110332311

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template team-extension-platform Extension Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants