Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #26459 +/- ##
========================================
Coverage 70.11% 70.12%
========================================
Files 1428 1428
Lines 50089 50090 +1
Branches 13894 13894
========================================
+ Hits 35119 35121 +2
+ Misses 14970 14969 -1 ☔ View full report in Codecov by Sentry. |
Collaborator
Builds ready [d6efa7f]
Page Load Metrics (147 ± 173 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
bergeron
approved these changes
Aug 16, 2024
vinnyhoward
approved these changes
Aug 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds NEAR Icon for ChainId
397and398. These chains are currently new networks being integrated onto EVM. They are currently in development, but it was requested from their team to preemptively add these icons, before production RPC endpoints are available.For context, here is their proposal: near/NEPs#518
https://chainlist.org/chain/397
https://chainlist.org/chain/398
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/MMASSETS-343
Manual testing steps
Once production RPCs are available, these icons should appear when NEAR RPC gets added in custom networks.
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist