Skip to content

fix: Update send transactions with custom nonce.csv#26451

Merged
sleepytanya merged 5 commits intodevelopfrom
sleepytanya-patch-1
Aug 16, 2024
Merged

fix: Update send transactions with custom nonce.csv#26451
sleepytanya merged 5 commits intodevelopfrom
sleepytanya-patch-1

Conversation

@sleepytanya
Copy link
Copy Markdown
Contributor

@sleepytanya sleepytanya commented Aug 15, 2024 •
edited
Loading

Updated the description to match the new UI for low nonce transaction: for now it is not displayed in a "Failed' state within the Activity list when the previous transaction with the same nonce made from the same instance.

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Verify that the test steps align with the sequence in the video.
  2. You can find steps here: https://github.com/MetaMask/metamask-extension/blob/0494f75984e7cb4e9ab569fcc0efe878f28adf99/test/manual-scenarios/transactions/send%20transactions%20with%20custom%20nonce.csv

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@sleepytanya
Update send transactions with custom nonce.csv
fa2c6c9 
Updated the description to match the new UI for low nonce transaction: for now it is not displayed in a "Failed' state within the Activity list when the previous transaction with the same nonce made from the same instance.
@sleepytanya sleepytanya requested a review from a team as a code owner August 15, 2024 18:48
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 15, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Aug 15, 2024
@MarketBeatAd
Copy link
Copy Markdown

MarketBeatAd commented Aug 15, 2024 via email

@sleepytanya sleepytanya changed the title Fix: Update send transactions with custom nonce.csv fix: Update send transactions with custom nonce.csv Aug 15, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.17%. Comparing base (7916145) to head (5669b14).

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #26451   +/-   ##
========================================
  Coverage    70.17%   70.17%           
========================================
  Files         1423     1423           
  Lines        49844    49844           
  Branches     13851    13851           
========================================
  Hits         34975    34975           
  Misses       14869    14869

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Aug 15, 2024

Builds ready [2cafd20]
Page Load Metrics (156 ± 180 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint692851095426
domContentLoaded993302110
load411787156376180
domInteractive993302110
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

benjisclowder
benjisclowder approved these changes Aug 15, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@benjisclowder benjisclowder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hjetpoluru hjetpoluru self-requested a review August 15, 2024 21:41
hjetpoluru
hjetpoluru approved these changes Aug 15, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@hjetpoluru hjetpoluru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Aug 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Aug 16, 2024

Builds ready [5669b14]
Page Load Metrics (185 ± 241 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6256012310450
domContentLoaded9259375326
load402371185502241
domInteractive9259375326
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@sleepytanya sleepytanya merged commit 0997f33 into develop Aug 16, 2024
@sleepytanya sleepytanya deleted the sleepytanya-patch-1 branch August 16, 2024 15:57
@github-actions github-actions bot locked and limited conversation to collaborators Aug 16, 2024
@metamaskbot metamaskbot added the release-12.5.0 Issue or pull request that will be included in release 12.5.0 label Aug 16, 2024
@gauthierpetetin gauthierpetetin added release-12.4.0 Issue or pull request that will be included in release 12.4.0 and removed release-12.5.0 Issue or pull request that will be included in release 12.5.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pedronfigueiredo pedronfigueiredo pedronfigueiredo approved these changes

@hjetpoluru hjetpoluru hjetpoluru approved these changes

+1 more reviewer

@benjisclowder benjisclowder benjisclowder approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-12.4.0 Issue or pull request that will be included in release 12.4.0 team-confirmations Push issues to confirmations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@sleepytanya @MarketBeatAd @metamaskbot @pedronfigueiredo @benjisclowder @hjetpoluru @gauthierpetetin