fix (patch): erc20 token prices on non-ETH networks#26450
Merged
danjm merged 2 commits intoVersion-v12.0.5from Aug 16, 2024
Merged
fix (patch): erc20 token prices on non-ETH networks#26450danjm merged 2 commits intoVersion-v12.0.5from
danjm merged 2 commits intoVersion-v12.0.5from
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
bergeron
commented
Aug 15, 2024
| @@ -0,0 +1,52 @@ | |||
| diff --git a/dist/chunk-6W5EQ3JQ.js b/dist/chunk-6W5EQ3JQ.js | |||
Contributor
Author
There was a problem hiding this comment.
I patched both the .js and .mjs files, because I wasn't sure which was necessary
Collaborator
Builds ready [ece9eff]
Page Load Metrics (139 ± 177 ms)
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## Version-v12.0.5 #26450 +/- ##
================================================
Coverage 65.75% 65.75%
================================================
Files 1372 1372
Lines 54782 54782
Branches 14262 14262
================================================
Hits 36020 36020
Misses 18762 18762 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue with erc20 token prices on networks where ETH is not the native currency.
When the price API does not support the native currency (e.g. MATIC), prices are fetched in ETH and an additional conversion hop is performed. But the extension was using the raw value without this additional hop.
This PR patches the relevant parts of MetaMask/core#4364.
Because that change is already in 12.1.0, this patch will no longer be needed in that version.
Related issues
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist