feat(notifications): use notification services push controller#26448
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
… notify_840-use-notification-services-push-controller
|
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is network access?This module accesses the network. Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
… notify_840-use-notification-services-push-controller
| 'app/scripts/constants/**/*.ts', | ||
| 'app/scripts/platforms/**/*.js', | ||
| 'app/scripts/controllers/push-platform-notifications/utils/get-notification-message.ts', | ||
| 'app/scripts/controllers/**/*.ts', |
There was a problem hiding this comment.
Updating this setting as this file does not exist.
We still have translation strings inside the /controllers folder (e.g. the translations for push notifications, this unfortunately cannot be shared cross platform).
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #26448 +/- ##
===========================================
+ Coverage 70.12% 70.18% +0.06%
===========================================
Files 1428 1423 -5
Lines 50089 49859 -230
Branches 13894 13854 -40
===========================================
- Hits 35120 34990 -130
+ Misses 14969 14869 -100 ☔ View full report in Codecov by Sentry. |
Builds ready [051a485]
Page Load Metrics (65 ± 10 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [e8dec1f]
Page Load Metrics (146 ± 148 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
Builds ready [099abdf]
Page Load Metrics (282 ± 287 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
This is another incremental migration, to use the shared/core libraries. This replaces the extension push controller for the
@metamask/notification-services-controllerpush service controller.Related issues
N/A
Manual testing steps
Test full notifications flow, specifically the push notifications.
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist