Skip to content

Version v12.0.4 RC#26427

Merged
danjm merged 4 commits intomasterfrom
Version-v12.0.4
Aug 15, 2024
Merged

Version v12.0.4 RC#26427
danjm merged 4 commits intomasterfrom
Version-v12.0.4

Conversation

@metamaskbot
Copy link
Copy Markdown
Collaborator

📦 🚀

@Gudahtt
Copy link
Copy Markdown
Member

Gudahtt commented Aug 14, 2024

@metamaskbot update-attributions

@metamaskbot
Copy link
Copy Markdown
Collaborator Author

Attributions updated

Gudahtt and others added 2 commits August 14, 2024 21:20
Cherry-pick of #26428 for v12.0.4. Original description:

## **Description**

The `SelectedNetworkController` state is cleared if any invalid
`networkConfigurationId`s are found in state. We are seeing reports of
this happening in production in v12.0.1.

The suspected cause is `NetworkController` state corruption. We resolved
a few cases of this in v12.0.1, but for users that were affected by
this, the invalid IDs may have propogated to the
`SelectedNetworkController` state already. That is what this migration
intends to fix.

[![Open in GitHub

Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/26428?quickstart=1)

## **Related issues**

Fixes #26309

## **Manual testing steps**

We don't have clear reproduction steps for the bug itself. To
artificially reproduce the scenario by changing extension state, this
should work:

* Create a dev build from v12.0.2
* Install the dev build from the `dist/chrome` directory and proceed
through onboarding
* Visit the test dapp, refresh, and connect to it.
* Run this command in the background console:
``` chrome.storage.local.get( null, (state) => {

state.data.SelectedNetworkController.domains['https://metamask.github.io'] = '123';
      chrome.storage.local.set(state, () => chrome.runtime.reload());
    }
  );
  ```
  * The linked error should now appear in the console of the popup
* Disable the extension
* Switch to this branch and create a dev build
* Enable and reload the extension
  * The error should no longer appear.

## **Screenshots/Recordings**

N/A

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable
- [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@danjm danjm marked this pull request as ready for review August 15, 2024 04:43
@danjm danjm requested a review from a team as a code owner August 15, 2024 04:43
@danjm danjm merged commit 1e348f8 into master Aug 15, 2024
@danjm danjm deleted the Version-v12.0.4 branch August 15, 2024 04:43
@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator Author

Builds ready [9f9948f]
Page Load Metrics (139 ± 181 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint71224933215
domContentLoaded9221131
load431780139377181
domInteractive9221131

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants